Avoid using 'solution crawler' terminology in the VSCode option name

Author: mavasani

package.json

@@ -1274,7 +1274,7 @@
             "description": "Show regular expressions in completion list.",
             "order": 20
           },
-          "dotnet.backgroundAnalysis.solutionCrawlerBackgroundAnalysisScope": {
+          "dotnet.backgroundAnalysis.analyzerDiagnosticsScope": {
             "type": "string",
             "enum": [
               "openFiles",

src/lsptoolshost/OptionNameConverter.ts

@@ -30,6 +30,12 @@ export function convertServerOptionNameToClientConfigurationName(section: string
         let optionNamePrefix = getPrefix(optionName, prefixes);
 
         let featureName = optionNamePrefix == '' ? optionName: optionName.substring(optionNamePrefix.length + 1);
+        
+        // Handle special case for background analysis option: we want to avoid
+        // 'solution crawler' terminology in the user facing VSCode option.
+        if (featureName =="solution_crawler_background_analysis_scope") {
+            featureName = "analyzer_diagnostics_scope";
+        }
 
         // Finally, convert everything to camel case and put them together.
         let camelCaseGroupName = convertToCamelCase(optionGroupName, '_');

test/unitTests/lspToolHost/configurationMiddleware.test.ts

@@ -45,7 +45,7 @@ const testData = [
     { serverOption: "csharp|code_style.formatting.indentation_and_spacing.indent_style", vsCodeConfiguration: "codeStyle.formatting.indentationAndSpacing.indentStyle", declareInPackageJson: false},
     { serverOption: "csharp|code_style.formatting.new_line.end_of_line", vsCodeConfiguration: "codeStyle.formatting.newLine.endOfLine", declareInPackageJson: false},
     { serverOption: "code_style.formatting.new_line.insert_final_newline", vsCodeConfiguration: "codeStyle.formatting.newLine.insertFinalNewline", declareInPackageJson: false},
-    { serverOption: "mystery_language|background_analysis.dotnet_solution_crawler_background_analysis_scope", vsCodeConfiguration: "dotnet.backgroundAnalysis.solutionCrawlerBackgroundAnalysisScope", declareInPackageJson: true},
+    { serverOption: "mystery_language|background_analysis.dotnet_solution_crawler_background_analysis_scope", vsCodeConfiguration: "dotnet.backgroundAnalysis.analyzerDiagnosticsScope", declareInPackageJson: true},
     { serverOption: "mystery_language|background_analysis.dotnet_compiler_diagnostics_scope", vsCodeConfiguration: "dotnet.backgroundAnalysis.compilerDiagnosticsScope", declareInPackageJson: true},
 ];