Skip to content

Commit 1a814f8

Browse files
committed
Enable more tests
1 parent f925910 commit 1a814f8

File tree

6 files changed

+9
-18
lines changed

6 files changed

+9
-18
lines changed

src/System.Private.ServiceModel/tests/Scenarios/Binding/Http/NetHttpBindingTests.4.0.0.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
public class Binding_Http_NetHttpBindingTests : ConditionalWcfTest
1111
{
1212
[WcfTheory]
13-
[Condition(nameof(Skip_CoreWCFService_FailedTest))]
1413
[InlineData(NetHttpMessageEncoding.Binary)]
1514
[InlineData(NetHttpMessageEncoding.Text)]
1615
[InlineData(NetHttpMessageEncoding.Mtom)]

src/System.Private.ServiceModel/tests/Scenarios/Binding/Http/NetHttpsBindingTests.4.1.0.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ public class Binding_Http_NetHttpsBindingTests : ConditionalWcfTest
1515
[InlineData(NetHttpMessageEncoding.Mtom)]
1616
[Issue(3572, OS = OSID.OSX)]
1717
[Condition(nameof(Root_Certificate_Installed),
18-
nameof(SSL_Available),
19-
nameof(Skip_CoreWCFService_FailedTest))]
18+
nameof(SSL_Available))]
2019
[OuterLoop]
2120
public static void DefaultCtor_NetHttps_Echo_RoundTrips_String(NetHttpMessageEncoding messageEncoding)
2221
{
@@ -83,8 +82,7 @@ public static void TransportWithMessageCredential_NotSupported_NetHttps()
8382
[WcfFact]
8483
[Issue(3572, OS = OSID.OSX)]
8584
[Condition(nameof(Root_Certificate_Installed),
86-
nameof(SSL_Available),
87-
nameof(Skip_CoreWCFService_FailedTest))]
85+
nameof(SSL_Available))]
8886
[OuterLoop]
8987
public static void NonDefaultCtor_NetHttps_Echo_RoundTrips_String()
9088
{

src/System.Private.ServiceModel/tests/Scenarios/Client/ClientBase/ClientBaseTests.4.1.0.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ public static void DefaultSettings_Echo_Cookie()
5555
}
5656

5757
[WcfFact]
58-
[Condition(nameof(Skip_CoreWCFService_FailedTest))]
5958
[OuterLoop]
6059
public static void DefaultSettings_SetCookieOnServerSide()
6160
{

src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Https/HttpsTests.4.1.1.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ public static void Https_SecModeTrans_CertValMode_PeerTrust_Fails_Not_In_Trusted
125125
[WcfFact]
126126
[Condition(nameof(Root_Certificate_Installed),
127127
nameof(Client_Certificate_Installed),
128-
nameof(SSL_Available),
129-
nameof(Skip_CoreWCFService_FailedTest))]
128+
nameof(SSL_Available))]
130129
[Issue(1945, OS = OSID.OSX)] // OSX doesn't support the TrustedPeople certificate store
131130
[OuterLoop]
132131
// Asking for PeerOrChainTrust should succeed if the certificate is
@@ -175,8 +174,7 @@ public static void Https_SecModeTrans_CertValMode_PeerOrChainTrust_Succeeds_Chai
175174
[Issue(2870, OS = OSID.OSX)]
176175
[Condition(nameof(Root_Certificate_Installed),
177176
nameof(Client_Certificate_Installed),
178-
nameof(SSL_Available),
179-
nameof(Skip_CoreWCFService_FailedTest))]
177+
nameof(SSL_Available))]
180178
[OuterLoop]
181179
// Asking for ChainTrust should succeed if the certificate is
182180
// chain-trusted.

src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeCertificateCanonicalNameTests.4.1.0.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ public class Tcp_ClientCredentialTypeCertificateCanonicalNameTests : Conditional
2626

2727
[WcfFact]
2828
[Issue(3572, OS = OSID.OSX)]
29-
[Condition(nameof(Root_Certificate_Installed),
30-
nameof(Skip_CoreWCFService_FailedTest))]
29+
[Condition(nameof(Root_Certificate_Installed))]
3130
[OuterLoop]
3231
public static void Certificate_With_CanonicalName_Localhost_Address_EchoString()
3332
{
@@ -99,7 +98,7 @@ public static void Certificate_With_CanonicalName_Localhost_Address_EchoString()
9998

10099
[WcfFact]
101100
[Issue(3572, OS = OSID.OSX)]
102-
[Condition(nameof(Root_Certificate_Installed), nameof(Skip_CoreWCFService_FailedTest))]
101+
[Condition(nameof(Root_Certificate_Installed))]
103102
[OuterLoop]
104103
public static void Certificate_With_CanonicalName_DomainName_Address_EchoString()
105104
{
@@ -176,7 +175,7 @@ public static void Certificate_With_CanonicalName_DomainName_Address_EchoString(
176175

177176
[WcfFact]
178177
[Issue(3572, OS = OSID.OSX)]
179-
[Condition(nameof(Root_Certificate_Installed), nameof(Skip_CoreWCFService_FailedTest))]
178+
[Condition(nameof(Root_Certificate_Installed))]
180179
[OuterLoop]
181180
public static void Certificate_With_CanonicalName_Fqdn_Address_EchoString()
182181
{

src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.1.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ public partial class Tcp_ClientCredentialTypeTests : ConditionalWcfTest
1818
[Condition(nameof(Root_Certificate_Installed),
1919
nameof(Client_Certificate_Installed),
2020
nameof(Peer_Certificate_Installed),
21-
nameof(SSL_Available),
22-
nameof(Skip_CoreWCFService_FailedTest))]
21+
nameof(SSL_Available))]
2322
[OuterLoop]
2423
// Asking for PeerTrust alone should succeed
2524
// if the certificate is in the TrustedPeople store. For this test
@@ -125,8 +124,7 @@ public static void NetTcp_SecModeTrans_CertValMode_PeerTrust_Fails_Not_In_Truste
125124
[Issue(1945, OS = OSID.OSX)]
126125
[Condition(nameof(Root_Certificate_Installed),
127126
nameof(Client_Certificate_Installed),
128-
nameof(SSL_Available),
129-
nameof(Skip_CoreWCFService_FailedTest))]
127+
nameof(SSL_Available))]
130128
[OuterLoop]
131129
// Asking for PeerOrChainTrust should succeed if the certificate is
132130
// chain-trusted, even though it is not in the TrustedPeople store.

0 commit comments

Comments
 (0)