MS.VB.Forms.Tests is not testing design time scenarios, removing DT dependencies.

replaced BaseOutputPath with ArtifactsBinDir in projects
restored workaround to reference the right instance of System.Drawing facade assembly from tests

Author: Tanya-Solyanik

src/Microsoft.VisualBasic.Forms/tests/UnitTests/Microsoft.VisualBasic.Forms.Tests.vbproj

@@ -17,17 +17,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\..\System.Design\src\System.Design.Facade.csproj" />
     <ProjectReference Include="..\..\..\System.Drawing.Common\src\System.Drawing.Common.csproj" />
-    <ProjectReference Include="..\..\..\System.Drawing.Design\src\System.Drawing.Design.Facade.csproj" />
     <ProjectReference Include="..\..\..\System.Windows.Forms.Primitives\tests\TestUtilities\System.Windows.Forms.Primitives.TestUtilities.csproj" />
     <ProjectReference Include="..\..\..\test\util\System.Windows.Forms\System.Windows.Forms.TestUtilities.csproj" />
     <ProjectReference Include="..\..\src\Microsoft.VisualBasic.Forms.vbproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <!-- workaround for https://github.com/dotnet/sdk/issues/3254 -->
-    <Reference Include="$(BaseOutputPath)..\System.Drawing.Facade\$(Configuration)\$(SourceTargetFramework)\System.Drawing.dll" />
-  </ItemGroup>
-
 </Project>

src/System.Windows.Forms.Design/tests/UnitTests/System.Windows.Forms.Design.Tests.csproj

@@ -28,7 +28,7 @@
 
   <ItemGroup>
     <!-- workaround for https://github.com/dotnet/sdk/issues/3254 -->
-    <Reference Include="$(BaseOutputPath)..\System.Design.Facade\$(Configuration)\$(SourceTargetFramework)\System.Design.dll" />
+    <Reference Include="$(ArtifactsBinDir)\System.Design.Facade\$(Configuration)\$(SourceTargetFramework)\System.Design.dll" />
   </ItemGroup>
 
   <ItemGroup>

src/System.Windows.Forms/System/Windows/Forms/DataBinding/ControlBindingsCollection.cs

@@ -10,7 +10,7 @@ namespace System.Windows.Forms;
 ///  Represents the collection of data bindings for a control.
 /// </summary>
 [DefaultEvent(nameof(CollectionChanged))]
-[Editor($"System.Drawing.Design.UITypeEditor, {(Assemblies.SystemDrawing)}", typeof(UITypeEditor))]
+[Editor($"System.Drawing.Design.UITypeEditor, {Assemblies.SystemDrawing}", typeof(UITypeEditor))]
 [TypeConverter($"System.Windows.Forms.Design.ControlBindingsConverter, {Assemblies.SystemDesign}")]
 public class ControlBindingsCollection : BindingsCollection
 {

src/test/unit/System.Windows.Forms/System.Windows.Forms.Tests.csproj

@@ -31,14 +31,16 @@
     <ProjectReference Include="..\..\..\System.Private.Windows.Core\tests\System.Private.Windows.Core.Tests\System.Private.Windows.Core.Tests.csproj" />
     <ProjectReference Include="..\..\..\System.Windows.Forms\System.Windows.Forms.csproj" />
     <ProjectReference Include="..\..\..\System.Design\src\System.Design.Facade.csproj" />
+    <!-- This facade assembly is required to resolve UITypeEditor type from NETFX that is referenced in EditorAttributes -->
+    <ProjectReference Include="..\..\..\System.Drawing\src\System.Drawing.Facade.csproj" />
     <ProjectReference Include="..\..\..\System.Drawing.Design\src\System.Drawing.Design.Facade.csproj" />
     <ProjectReference Include="..\..\integration\System.Windows.Forms.IntegrationTests.Common\System.Windows.Forms.IntegrationTests.Common.csproj" />
     <ProjectReference Include="..\..\util\System.Windows.Forms\System.Windows.Forms.TestUtilities.csproj" />
   </ItemGroup>
 
   <ItemGroup>
     <!-- workaround for https://github.com/dotnet/sdk/issues/3254 -->
-    <Reference Include="$(BaseOutputPath)..\System.Drawing.Facade\$(Configuration)\$(SourceTargetFramework)\System.Drawing.dll" />
+    <Reference Include="$(ArtifactsBinDir)\System.Drawing.Facade\$(Configuration)\$(SourceTargetFramework)\System.Drawing.dll" />
   </ItemGroup>
 
   <ItemGroup>

src/test/unit/System.Windows.Forms/System/Windows/Forms/Design/DesignerAttributeTests.cs

@@ -171,7 +171,7 @@ public void TypeConverterAttribute_TypeExists(string subject, TypeConverterAttri
     [MemberData(nameof(GetAttributeOfTypeAndProperty_TestData), Assemblies.SystemWindowsForms, typeof(EditorAttribute))]
     public void EditorAttribute_TypeExists(string subject, EditorAttribute attribute)
     {
-        var type = Type.GetType(attribute.EditorTypeName, false);
+        var type = Type.GetType(attribute.EditorTypeName, throwOnError: false);
         _output.WriteLine($"{subject}: {attribute.EditorTypeName} --> {type?.Name}");
 
         if (SkipList.Contains(attribute.EditorTypeName))