React to NuGet package pruning warnings (2) (#12964)

* React to NuGet package pruning warnings (2)

Replaces #12960
Unsure why those weren't flagged in 9249b89
but this is the right thing to do.

Set PackageId for the facade project to avoid project prune warnings.

* Update comments in Microsoft.VisualBasic.Facade.csproj

* Update src/Microsoft.VisualBasic/src/Microsoft.VisualBasic.Facade.csproj

Co-authored-by: Alexander Köplinger <[email protected]>

---------

Co-authored-by: Alexander Köplinger <[email protected]>

Author: ViktorHofer

Directory.Packages.props

@@ -11,7 +11,6 @@
     <PackageVersion Include="Microsoft.Win32.SystemEvents" Version="$(MicrosoftWin32SystemEventsPackageVersion)" />
     <PackageVersion Include="Microsoft.Windows.CsWin32" Version="$(MicrosoftWindowsCsWin32PackageVersion)" PrivateAssets="all" />
     <PackageVersion Include="System.CodeDom" Version="$(SystemCodeDomPackageVersion)" />
-    <PackageVersion Include="System.Collections.Concurrent" Version="4.3.0" />
     <PackageVersion Include="System.ComponentModel.TypeConverter.TestData" Version="$(SystemComponentModelTypeConverterTestDataVersion)" />
     <PackageVersion Include="System.Configuration.ConfigurationManager" Version="$(SystemConfigurationConfigurationManagerPackageVersion)" />
     <PackageVersion Include="System.Data.SqlClient" Version="4.9.0" />

src/Common/tests/TestUtilities/System.Private.Windows.Core.TestUtilities.csproj

@@ -13,7 +13,6 @@
   <ItemGroup>
     <PackageReference Include="FluentAssertions" />
     <PackageReference Include="Moq" />
-    <PackageReference Include="System.Collections.Concurrent" />
     <PackageReference Include="xunit.assert" />
     <PackageReference Include="xunit.stafact" />
     <PackageReference Include="Microsoft.DotNet.RemoteExecutor" />

src/Microsoft.VisualBasic/src/Microsoft.VisualBasic.Facade.csproj

@@ -2,6 +2,10 @@
 
   <PropertyGroup>
     <AssemblyName>Microsoft.VisualBasic</AssemblyName>
+    <!-- Set PackageId to something different than the assembly name as NuGet prunes package and project
+         references for dependencies that are inbox in the framework. NuGet uses the PackageId information
+         for that. This is necessary for this facadeproject as Microsoft.VisualBasic is inbox on .NETCoreApp. -->
+    <PackageId>$(MSBuildProjectName)</PackageId>
   </PropertyGroup>
 
   <ItemGroup>

src/System.Windows.Forms.Primitives/tests/TestUtilities/System.Windows.Forms.Primitives.TestUtilities.csproj

@@ -12,7 +12,6 @@
 
   <ItemGroup>
     <PackageReference Include="FluentAssertions" />
-    <PackageReference Include="System.Collections.Concurrent" />
     <PackageReference Include="Microsoft.DotNet.XUnitExtensions" />
   </ItemGroup>
 

src/System.Windows.Forms/tests/TestUtilities/System.Windows.Forms.TestUtilities.csproj

@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="System.Collections.Concurrent" />
     <PackageReference Include="Microsoft.DotNet.RemoteExecutor" />
     <PackageReference Include="Microsoft.DotNet.XUnitExtensions" />
   </ItemGroup>