PropertyGrid: PropertyGridView.DoubleClickRow - IndexOutOfRangeException

[ulfemsoy]

.NET version

.NET 9

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Not sure

Issue description

System.IndexOutOfRangeException: Index was outside the bounds of the array.
at System.Windows.Forms.PropertyGridInternal.PropertyGridView.DoubleClickRow(Int32 row, Boolean toggleExpand, Int32 type)
at System.Windows.Forms.PropertyGridInternal.GridEntry.OnMouseClick(Int32 x, Int32 y, Int32 count, MouseButtons button)
at System.Windows.Forms.PropertyGridInternal.PropertyGridView.OnMouseDown(MouseEventArgs e)
at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.PropertyGridInternal.PropertyGridView.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)

Steps to reproduce

Not sure.

[Zheng-Li01]

@ulfemsoy could you please provide more details to help reproduce the issue, such as stable steps or sample project?

[ulfemsoy]

@Zheng-Li01:
The issue was found in the error log. I'm not sure how to re-create the issue.
The Exception is thrown on line 1310:

CommitValue(values[index]);

Cause:
The following code does not take into account that the array could be empty (line 1301):
if (index >= (values.Length - 1)) { index = 0; } else { index++; }

--

The array (which could be empty) is returned from (line 1464):

///

/// Returns the standard text values of this property.
///

public virtual object[] GetPropertyValueList()
{
if (TypeConverter.GetStandardValues(this) is { } values)
{
object[] valueArray = new object[values.Count];
values.CopyTo(valueArray, 0);
return valueArray;
}

  return []; // CAUSING THE EXCEPTION

}

[Zheng-Li01]

@ulfemsoy thanks for your update. create the sample project based on your description with the help of Copilot but failed. attached the reproduce application, could you please have a check and try to modify it to help reproduce the issue.

ExceptionRepo.zip