Skip to content

Conversation

@Tanya-Solyanik
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik commented Mar 14, 2025

re-introduce #12881 to support the VMR build which uses an older version of Roslyn if dotnet/sdk#47167 is not fixed before Preview3.

Microsoft Reviewers: Open in CodeFlow

@Tanya-Solyanik Tanya-Solyanik added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 14, 2025
@Tanya-Solyanik Tanya-Solyanik requested a review from a team as a code owner March 14, 2025 18:40
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.35713%. Comparing base (7b4d380) to head (6c31646).
Report is 12 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13143         +/-   ##
===================================================
+ Coverage   61.34640%   61.35713%   +0.01072%     
===================================================
  Files           1547        1547                 
  Lines         158482      158482                 
  Branches       14752       14752                 
===================================================
+ Hits           97223       97240         +17     
+ Misses         60557       60538         -19     
- Partials         702         704          +2     
Flag Coverage Δ
Debug 61.35713% <ø> (+0.01072%) ⬆️
integration 10.72837% <ø> (-0.00418%) ⬇️
production 39.22997% <ø> (+0.01764%) ⬆️
test 95.67947% <ø> (ø)
unit 36.66667% <ø> (+0.02283%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik changed the title DIsable IDE0082 in the VMR build Disable IDE0082 in the VMR build Mar 14, 2025
@ViktorHofer ViktorHofer removed the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 17, 2025
@ViktorHofer
Copy link
Member

I'm going to merge this in to unblock the dependency flow. We can revert this when the re-bootstrap is done: dotnet/sdk#47447

@ViktorHofer ViktorHofer merged commit eb7e0d5 into dotnet:main Mar 17, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Mar 17, 2025
ViktorHofer added a commit that referenced this pull request Mar 18, 2025
ViktorHofer added a commit that referenced this pull request Mar 19, 2025
Revert "Disable IDE0082 in the VMR build (#13143)"

This reverts commit eb7e0d5.
@Tanya-Solyanik Tanya-Solyanik deleted the vmr-gate branch April 3, 2025 17:47
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants