Try fix GetHashCode implementation of the Thickness struct is broken for uniform length (#8822)

lindexi · web-flow · commit 21ed23c1e862 · 2024-09-18T19:58:18.000+05:30
* Try fix GetHashCode implementation of the Thickness struct is broken for uniform length #8789 * Use clean code.
diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Thickness.cs b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Thickness.cs
@@ -95,7 +95,7 @@ public bool Equals(Thickness thickness)
         /// <returns>Hash code</returns>
         public override int GetHashCode()
         {
-            return _Left.GetHashCode() ^ _Top.GetHashCode() ^ _Right.GetHashCode() ^ _Bottom.GetHashCode();
+            return System.HashCode.Combine(_Left, _Top, _Right, _Bottom);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public bool Equals(Thickness thickness)`
`95`	`95`	`/// <returns>Hash code</returns>`
`96`	`96`	`public override int GetHashCode()`
`97`	`97`	`{`
`98`		`- return _Left.GetHashCode() ^ _Top.GetHashCode() ^ _Right.GetHashCode() ^ _Bottom.GetHashCode();`
	`98`	`+ return System.HashCode.Combine(_Left, _Top, _Right, _Bottom);`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`/// <summary>`