Skip to content

Commit 3240516

Browse files
author
Mirroring
committed
Merge commit '8f5beb8e18952199c7a87e7c0a7f291b22e69644'
2 parents 380ceef + 8f5beb8 commit 3240516

File tree

13 files changed

+323
-138
lines changed

13 files changed

+323
-138
lines changed

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,11 @@ internal static void OnSystemThemeChanged()
2828

2929
FluentThemeState newFluentThemeState = new FluentThemeState(Application.Current.ThemeMode.Value, useLightColors);
3030

31-
if (s_currentFluentThemeState == newFluentThemeState)
31+
if (s_currentFluentThemeState != newFluentThemeState)
3232
{
33-
return;
33+
AddOrUpdateThemeResources(Application.Current.Resources, GetThemeDictionary(Application.Current.ThemeMode));
3434
}
3535

36-
AddOrUpdateThemeResources(Application.Current.Resources, GetThemeDictionary(Application.Current.ThemeMode));
37-
3836
foreach (Window window in Application.Current.Windows)
3937
{
4038
if (window.ThemeMode == ThemeMode.None)

src/Microsoft.DotNet.Wpf/src/Themes/Generator/ThemeGenerator.Fluent.ps1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ foreach($themeColor in $themeColors)
2020
xmlns:system="clr-namespace:System;assembly=System.Runtime"
2121
xmlns:ui="clr-namespace:System.Windows.Documents;assembly=PresentationUI"
2222
xmlns:theme="clr-namespace:Microsoft.Windows.Themes"
23-
xmlns:framework="clr-namespace:MS.Internal;assembly=PresentationFramework"
23+
xmlns:ms="clr-namespace:MS.Internal;assembly=PresentationFramework"
24+
xmlns:standard="clr-namespace:Standard;assembly=PresentationFramework"
2425
xmlns:base="clr-namespace:System.Windows;assembly=WindowsBase">
2526
</ResourceDictionary>'
2627

src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Controls/AnimationFactorToValueConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
1717
return 0.0;
1818
}
1919

20-
if (values[1] is not double factor)
20+
if (values[1] is not double factor || factor == double.NaN)
2121
{
2222
return 0.0;
2323
}

src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/Dark.xaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,6 +506,7 @@
506506
<SolidColorBrush x:Key="LabelForeground" Color="{StaticResource TextFillColorPrimary}" />
507507

508508
<!-- ListBox -->
509+
<Color x:Key="SystemChromeMediumLowColor">#FF2B2B2B</Color>
509510
<SolidColorBrush x:Key="ListBoxBackground" Color="{StaticResource CardBackgroundFillColorDefault}" />
510511
<SolidColorBrush x:Key="ListBoxItemForeground" Color="{StaticResource TextFillColorPrimary}" />
511512
<SolidColorBrush x:Key="ListBoxItemSelectedBackgroundThemeBrush" Color="{StaticResource SystemAccentColor}" Opacity="0.6" />
@@ -578,7 +579,7 @@
578579
<SolidColorBrush x:Key="RadioButtonBackground" Color="{StaticResource SubtleFillColorTransparent}"/>
579580
<SolidColorBrush x:Key="RadioButtonBackgroundPointerOver" Color="{StaticResource SubtleFillColorTransparent}"/>
580581
<SolidColorBrush x:Key="RadioButtonBackgroundPressed" Color="{StaticResource SubtleFillColorTransparent}"/>
581-
<SolidColorBrush x:Key="RadioButtonBackgroundDisabled" Color="{StaticResource TextFillColorDisabled}" />
582+
<SolidColorBrush x:Key="RadioButtonBackgroundDisabled" Color="{StaticResource ControlFillColorTransparent}" />
582583
<SolidColorBrush x:Key="RadioButtonBorderBrush" Color="{StaticResource SubtleFillColorTransparent}"/>
583584
<SolidColorBrush x:Key="RadioButtonBorderBrushPointerOver" Color="{StaticResource SubtleFillColorTransparent}"/>
584585
<SolidColorBrush x:Key="RadioButtonBorderBrushPressed" Color="{StaticResource SubtleFillColorTransparent}"/>
@@ -597,6 +598,8 @@
597598
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokePressed" Color="{StaticResource ControlStrongStrokeColorDisabled}" />
598599
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokeDisabled" Color="{StaticResource ControlStrongStrokeColorDisabled}" />
599600
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFill" Color="{StaticResource SystemAccentColorLight2}"/>
601+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFillDisabled" Color="{StaticResource AccentFillColorDisabled}" />
602+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedStrokeDisabled" Color="{StaticResource AccentFillColorDisabled}" />
600603

601604
<!-- RatingControl -->
602605
<SolidColorBrush x:Key="RatingControlSelectedForeground" Color="{StaticResource SystemAccentColorLight2}" />

src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/HC.xaml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383

8484
<SolidColorBrush x:Key="ControlSolidFillColorDefaultBrush" Color="{StaticResource SystemColorButtonFaceColor}" />
8585

86-
<SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="Transparent" />
86+
<SolidColorBrush x:Key="SubtleFillColorTransparentBrush" Color="Transparent" />
8787
<SolidColorBrush x:Key="SubtleFillColorSecondaryBrush" Color="{StaticResource SystemColorButtonFaceColor}" />
8888
<SolidColorBrush x:Key="SubtleFillColorTertiaryBrush" Color="{StaticResource SystemColorButtonFaceColor}" />
8989
<SolidColorBrush x:Key="SubtleFillColorDisabledBrush" Color="{StaticResource SystemColorButtonFaceColor}" />
@@ -381,10 +381,12 @@
381381
<SolidColorBrush x:Key="LabelForeground" Color="{StaticResource SystemColorGrayTextColor}" />
382382

383383
<!-- ListBox -->
384+
<Color x:Key="SystemChromeMediumLowColor">#FF2B2B2B</Color>
384385
<SolidColorBrush x:Key="ListBoxBackground" Color="{StaticResource SystemColorButtonFaceColor}" />
385386
<SolidColorBrush x:Key="ListBoxItemForeground" Color="{StaticResource SystemColorWindowTextColor}" />
386387
<SolidColorBrush x:Key="ListBoxItemSelectedBackgroundThemeBrush" Color="{StaticResource SystemColorHighlightColor}" />
387388
<SolidColorBrush x:Key="ListBoxItemSelectedBackgroundPointerOverThemeBrush" Color="{StaticResource SystemColorButtonTextColor}" />
389+
<SolidColorBrush x:Key="ListBoxItemBackgroundSelectedPressedThemeBrush" Color="{StaticResource SystemColorHighlightColor}"/>
388390
<SolidColorBrush x:Key="ListBoxItemSelectedForegroundThemeBrush" Color="{StaticResource SystemColorButtonFaceColor}" />
389391
<SolidColorBrush x:Key="ListBoxItemUnselectedBackgroundPointerOverThemeBrush" Color="{StaticResource SystemColorHighlightTextColor}" />
390392

@@ -453,7 +455,7 @@
453455
<SolidColorBrush x:Key="RadioButtonBackground" Color="Transparent"/>
454456
<SolidColorBrush x:Key="RadioButtonBackgroundPointerOver" Color="Transparent"/>
455457
<SolidColorBrush x:Key="RadioButtonBackgroundPressed" Color="Transparent"/>
456-
<SolidColorBrush x:Key="RadioButtonBackgroundDisabled" Color="{StaticResource SystemColorGrayTextColor}" />
458+
<SolidColorBrush x:Key="RadioButtonBackgroundDisabled" Color="Transparent" />
457459
<SolidColorBrush x:Key="RadioButtonBorderBrush" Color="Transparent"/>
458460
<SolidColorBrush x:Key="RadioButtonBorderBrushPointerOver" Color="Transparent"/>
459461
<SolidColorBrush x:Key="RadioButtonBorderBrushPressed" Color="Transparent"/>
@@ -471,7 +473,9 @@
471473
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokePointerOver" Color="{StaticResource SystemColorHighlightColor}" />
472474
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokePressed" Color="{StaticResource SystemColorHighlightTextColor}" />
473475
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokeDisabled" Color="{StaticResource SystemColorGrayTextColor}" />
474-
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFill" Color="{StaticResource SystemColorHighlightColor}"/>
476+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFill" Color="{StaticResource SystemColorHighlightTextColor}"/>
477+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFillDisabled" Color="{StaticResource SystemColorWindowColor}" />
478+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedStrokeDisabled" Color="{StaticResource SystemColorGrayTextColor}" />
475479

476480
<!-- RatingControl -->
477481
<SolidColorBrush x:Key="RatingControlSelectedForeground" Color="{StaticResource SystemColorHighlightColor}" />
@@ -533,6 +537,9 @@
533537
<SolidColorBrush x:Key="TextControlPlaceholderForeground" Color="{StaticResource SystemColorGrayTextColor}" />
534538
<SolidColorBrush x:Key="TextControlButtonForeground" Color="{StaticResource SystemColorWindowTextColor}" />
535539

540+
<!-- ThumbRate -->
541+
<SolidColorBrush x:Key="ThumbRateForeground" Color="{StaticResource SystemColorHighlightColor}" />
542+
536543
<!-- TimePicker -->
537544
<SolidColorBrush x:Key="TimePickerButtonBackground" Color="{StaticResource SystemColorWindowColor}" />
538545
<SolidColorBrush x:Key="TimePickerButtonBackgroundPointerOver" Color="{StaticResource SystemColorHighlightTextColor}" />
@@ -636,7 +643,7 @@
636643

637644
<Color x:Key="ControlSolidFillColorDefault">#2D3236</Color>
638645

639-
<Color x:Key="SystemColorWindowColor">Transparent</Color>
646+
<Color x:Key="SubtleFillColorTransparent">#2D3236</Color>
640647
<Color x:Key="SubtleFillColorSecondary">#2D3236</Color>
641648
<Color x:Key="SubtleFillColorTertiary">#2D3236</Color>
642649
<Color x:Key="SubtleFillColorDisabled">#2D3236</Color>

src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/Light.xaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@
576576
<SolidColorBrush x:Key="RadioButtonBackground" Color="{StaticResource SubtleFillColorTransparent}"/>
577577
<SolidColorBrush x:Key="RadioButtonBackgroundPointerOver" Color="{StaticResource SubtleFillColorTransparent}"/>
578578
<SolidColorBrush x:Key="RadioButtonBackgroundPressed" Color="{StaticResource SubtleFillColorTransparent}"/>
579-
<SolidColorBrush x:Key="RadioButtonBackgroundDisabled" Color="{StaticResource TextFillColorDisabled}" />
579+
<SolidColorBrush x:Key="RadioButtonBackgroundDisabled" Color="{StaticResource ControlFillColorTransparent}" />
580580
<SolidColorBrush x:Key="RadioButtonBorderBrush" Color="{StaticResource SubtleFillColorTransparent}"/>
581581
<SolidColorBrush x:Key="RadioButtonBorderBrushPointerOver" Color="{StaticResource SubtleFillColorTransparent}"/>
582582
<SolidColorBrush x:Key="RadioButtonBorderBrushPressed" Color="{StaticResource SubtleFillColorTransparent}"/>
@@ -595,6 +595,9 @@
595595
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokePressed" Color="{StaticResource ControlStrongStrokeColorDisabled}" />
596596
<SolidColorBrush x:Key="RadioButtonOuterEllipseStrokeDisabled" Color="{StaticResource ControlStrongStrokeColorDisabled}" />
597597
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFill" Color="{StaticResource SystemAccentColorDark1}"/>
598+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedFillDisabled" Color="{StaticResource AccentFillColorDisabled}" />
599+
<SolidColorBrush x:Key="RadioButtonOuterEllipseCheckedStrokeDisabled" Color="{StaticResource AccentFillColorDisabled}" />
600+
598601

599602
<!-- RatingControl -->
600603
<SolidColorBrush x:Key="RatingControlSelectedForeground" Color="{StaticResource SystemAccentColorDark1}" />

0 commit comments

Comments
 (0)