[StyleCleanUp] Remove unnecessary equality operator (IDE0100) (#10643)

* Fix IDE0100 in PBT

* Fix IDE0100 in PresentationCore

* Fix IDE0100 in PresentationFramework

* Fix IDE0100 in PresentationUI

* Fix IDE0100 in ReachFramework

* Fix IDE0100 in Ribbon

* Fix IDE0100 in WindowsBase

* Fix IDE0100 in System.Xaml

* Fix IDE0100 in Shared files

* Fix the rest of IDE0100

* Adjust .editorconfig

* Fix whitespace issues

* One more spacing issue

Author: h3xds1nz

src/Microsoft.DotNet.Wpf/src/.editorconfig

@@ -206,9 +206,6 @@ dotnet_diagnostic.IDE0077.severity = suggestion
 # IDE0078: Use pattern matching
 dotnet_diagnostic.IDE0078.severity = suggestion
 
-# IDE0100: Remove redundant equality
-dotnet_diagnostic.IDE0100.severity = suggestion
-
 # IDE0180: Use tuple to swap values
 dotnet_diagnostic.IDE0180.severity = suggestion
 

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/MarkupCompiler.cs

@@ -3353,7 +3353,7 @@ private string GetSplashResourceId()
                 relPath = TaskHelper.GetRootRelativePath(Directory.GetCurrentDirectory() + Path.DirectorySeparatorChar, fullFilePath);
             }
 
-            if (string.IsNullOrEmpty(relPath) == false)
+            if (!string.IsNullOrEmpty(relPath))
             {
                 resourceId = relPath;
             }

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/CompilerLocalReference.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 //----------------------------------------------------------------------------------------
@@ -173,7 +173,7 @@ internal void CleanupCache()
         //
         internal bool SaveCacheInformation(MarkupCompilePass1 mcPass1)
         {
-            Debug.Assert(String.IsNullOrEmpty(_localCacheFile) != true, "_localCacheFile must not be empty.");
+            Debug.Assert(!String.IsNullOrEmpty(_localCacheFile), "_localCacheFile must not be empty.");
             Debug.Assert(mcPass1 != null, "A valid instance of MarkupCompilePass1 must be passed to method SaveCacheInformation.");
 
             bool bSuccess = false;
@@ -235,7 +235,7 @@ internal bool SaveCacheInformation(MarkupCompilePass1 mcPass1)
         //
         internal bool LoadCacheFile()
         {
-            Debug.Assert(String.IsNullOrEmpty(_localCacheFile) != true, "_localCacheFile must not be empty.");
+            Debug.Assert(!String.IsNullOrEmpty(_localCacheFile), "_localCacheFile must not be empty.");
 
             bool loadSuccess = false;
 
@@ -261,7 +261,7 @@ internal bool LoadCacheFile()
 
                 ArrayList alMarkupPages = new ArrayList();
 
-                while (srCache.EndOfStream != true)
+                while (!srCache.EndOfStream)
                 {
                     lineText = srCache.ReadLine();
                     LocalReferenceFile lrf = LocalReferenceFile.Deserialize(lineText);

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/CompilerState.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 //----------------------------------------------------------------------------------------
@@ -87,7 +87,7 @@ internal void CleanupCache()
 
         internal bool SaveStateInformation(MarkupCompilePass1 mcPass1)
         {
-            Debug.Assert(String.IsNullOrEmpty(_stateFilePath) != true, "StateFilePath must not be empty.");
+            Debug.Assert(!String.IsNullOrEmpty(_stateFilePath), "StateFilePath must not be empty.");
             Debug.Assert(mcPass1 != null, "A valid instance of MarkupCompilePass1 must be passed to method SaveCacheInformation.");
             Debug.Assert(_cacheInfoList.Length == (int)CompilerStateType.MaxCount, "The Cache string array should be already allocated.");
 
@@ -148,7 +148,7 @@ internal bool SaveStateInformation()
         //
         internal bool LoadStateInformation( )
         {
-            Debug.Assert(String.IsNullOrEmpty(_stateFilePath) != true, "_stateFilePath must be not be empty.");
+            Debug.Assert(!String.IsNullOrEmpty(_stateFilePath), "_stateFilePath must be not be empty.");
             Debug.Assert(_cacheInfoList.Length == (int)CompilerStateType.MaxCount, "The Cache string array should be already allocated.");
 
             bool loadSuccess = false;
@@ -176,7 +176,7 @@ internal bool LoadStateInformation( )
 
                 int i = 0;
 
-                while (srCache.EndOfStream != true)
+                while (!srCache.EndOfStream)
                 {
                     if (i >= (int)CompilerStateType.MaxCount)
                     {

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/TaskHelper.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 //-----------------------------------------------------------------------------
@@ -207,7 +207,7 @@ internal static string GetWholeExceptionMessage(Exception exception)
                 e = eInner;
             }
 
-            if (message != null && message.EndsWith(".", StringComparison.Ordinal) == false)
+            if (message != null && !message.EndsWith(".", StringComparison.Ordinal))
             {
                 message += ".";
             }

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/FileClassifier.cs

@@ -77,7 +77,7 @@ public override bool Execute()
 
                 ret = VerifyTaskInputs();
 
-                if (ret != false)
+                if (ret)
                 {
                     // Do the real work to classify input files.
                     Classify(SourceFiles, mainEmbeddedList, satelliteEmbeddedList);
@@ -276,7 +276,7 @@ private bool VerifyTaskInputs()
             // MSBUILD Engine should have checked the setting for this property
             // so don't need to recheck here.
 
-            if (TaskHelper.IsValidCultureName(Culture) == false)
+            if (!TaskHelper.IsValidCultureName(Culture))
             {
                 Log.LogErrorWithCodeFromResources(nameof(SR.InvalidCulture), Culture);
                 bValidInput = false;

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/GenerateTemporaryTargetAssembly.cs

@@ -618,7 +618,7 @@ private void RemoveEntityByName(XmlDocument xmlProjectDoc, string sItemName, str
 
             XmlNode root = xmlProjectDoc.DocumentElement;
 
-            if (root.HasChildNodes == false)
+            if (!root.HasChildNodes)
             {
                 // If there is no child element in this project file, just return immediatelly.
                 return;

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/MarkupCompilePass1.cs

@@ -973,7 +973,7 @@ private bool IsSupportedOutputType(string outputType)
                     break;
             }
 
-            if (isSupported == false)
+            if (!isSupported)
             {
                 Log.LogErrorWithCodeFromResources(nameof(SR.TargetIsNotSupported), outputType);
 
@@ -1019,7 +1019,7 @@ private bool VerifyInputTaskItems(ITaskItem[] inputItems)
 
                 bValidItem = IsValidInputFile(inputItem.ItemSpec);
 
-                if (bValidItem == false)
+                if (!bValidItem)
                 {
                     bValid = false;
                 }

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/MarkupCompilePass2.cs

@@ -817,7 +817,7 @@ private bool IsSupportedOutputType(string outputType)
                     break;
             }
 
-            if (isSupported == false)
+            if (!isSupported)
             {
                 Log.LogErrorWithCodeFromResources(nameof(SR.TargetIsNotSupported), outputType);
 

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/ResourcesGenerator.cs

@@ -146,7 +146,7 @@ public override bool Execute()
             // Validate the property settings
             //
 
-            if (ValidResourceFiles(ResourceFiles) == false)
+            if (!ValidResourceFiles(ResourceFiles))
             {
                // ValidResourceFiles has already showed up error message.
                // Just stop here.