simplify GetSuggestionsForError, use inline var declarations

Author: h3xds1nz

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/Speller.cs

@@ -179,33 +179,22 @@ internal ITextPointer GetNextSpellingErrorPosition(ITextPointer position, Logica
         // re-evaluating the error from scratch.
         internal List<string> GetSuggestionsForError(SpellingError error)
         {
-            ITextPointer contextStart;
-            ITextPointer contextEnd;
-            ITextPointer contentStart;
-            ITextPointer contentEnd;
-            TextMap textMap;
-
-            List<string> suggestions = new();
-
             //
             // IMPORTANT!!
             //
             // This logic here must match ScanRange, or else we might not
             // calculate the exact same error.  Keep the two methods in sync!
             //
 
-            XmlLanguage language;
-            CultureInfo culture = GetCurrentCultureAndLanguage(error.Start, out language);
-            if (culture == null || !_spellerInterop.CanSpellCheck(culture))
-            {
-                // Return an empty list.
-            }
-            else
+            List<string> suggestions = new();
+            CultureInfo culture = GetCurrentCultureAndLanguage(error.Start, out XmlLanguage language);
+
+            if (culture is not null || _spellerInterop.CanSpellCheck(culture))
             {
-                ExpandToWordBreakAndContext(error.Start, LogicalDirection.Backward, language, out contentStart, out contextStart);
-                ExpandToWordBreakAndContext(error.End, LogicalDirection.Forward, language, out contentEnd, out contextEnd);
+                ExpandToWordBreakAndContext(error.Start, LogicalDirection.Backward, language, out ITextPointer contentStart, out ITextPointer contextStart);
+                ExpandToWordBreakAndContext(error.End, LogicalDirection.Forward, language, out ITextPointer contentEnd, out ITextPointer contextEnd);
 
-                textMap = new TextMap(contextStart, contextEnd, contentStart, contentEnd);
+                TextMap textMap = new(contextStart, contextEnd, contentStart, contentEnd);
 
                 SetCulture(culture);