Merge pull request #9222 from h3xds1nz/replace-arraylist-with-preallocated-array

Replace ArrayList in CursorConverter with preallocated array and reduce allocations

Author: harshit7962

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/CursorConverter.cs

@@ -4,7 +4,6 @@
 
 using System.ComponentModel;
 using System.ComponentModel.Design.Serialization;
-using System.Collections;
 using System.Globalization;
 using System.Reflection;
 using System.Windows.Media; // TypeConverterHelper, UriHolder
@@ -53,35 +52,29 @@ public override bool CanConvertTo(ITypeDescriptorContext context, Type destinati
             return false;
         }
 
-        /// <summary>
-        ///     Gets the public/static properties of the Cursors class
-        /// </summary>
-        /// <returns>PropertyInfo array of the objects properties</returns>
-        private PropertyInfo[] GetProperties()
-        {
-            return typeof(Cursors).GetProperties(BindingFlags.Public | BindingFlags.Static);
-        }
-
         /// <summary>
         ///     StandardValuesCollection method override
         /// </summary>
         /// <param name="context">ITypeDescriptorContext</param>
         /// <returns>TypeConverter.StandardValuesCollection</returns>
         public override TypeConverter.StandardValuesCollection GetStandardValues(ITypeDescriptorContext context)
         {
-            if(this._standardValues == null)
+            if(_standardValues is null)
             {
-                ArrayList list1 = new ArrayList();
-                PropertyInfo[] infoArray1 = this.GetProperties();
-                for(int num1 = 0; num1 < infoArray1.Length; num1++)
+                PropertyInfo[] properties = typeof(Cursors).GetProperties(BindingFlags.Public | BindingFlags.Static);
+                object[] values = new object[properties.Length]; //Could use Cursor but its wrapped in ICollection anyways
+
+                for (int i = 0; i < properties.Length; i++)
                 {
-                    PropertyInfo info1 = infoArray1[num1];
-                    object[] objArray1 = null;
-                    list1.Add(info1.GetValue(null, objArray1));
+                    PropertyInfo info = properties[i];
+
+                    values[i] = info.GetValue(null, null);
                 }
-                this._standardValues = new TypeConverter.StandardValuesCollection(list1.ToArray());
+
+                _standardValues = new TypeConverter.StandardValuesCollection(values);
             }
-            return this._standardValues;
+
+            return _standardValues;
         }
 
         /// <summary>