Packet serialization optimization (#31)

Author: sunnycase

src/MineCase.Protocol/MineCase.Protocol.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard1.4</TargetFramework>
+    <TargetFramework>netstandard1.5</TargetFramework>
     <RootNamespace>MineCase</RootNamespace>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <CodeAnalysisRuleSet>../../build/Analyzers.ruleset</CodeAnalysisRuleSet>
@@ -10,6 +10,7 @@
   <ItemGroup>
     <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
     <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.3.0" />
+    <PackageReference Include="Microsoft.Orleans.Core" Version="2.0.0-preview2-20170724" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004" PrivateAssets="All" />
   </ItemGroup>
 

src/MineCase.Protocol/Protocol/Handshaking/Handshake.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Handshaking
 {
+    [Immutable]
     [Packet(0x00)]
     public sealed class Handshake
     {

src/MineCase.Protocol/Protocol/Login/LoginStart.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Login
 {
+    [Immutable]
     [Packet(0x00)]
     public sealed class LoginStart
     {
@@ -21,6 +23,7 @@ public static LoginStart Deserialize(BinaryReader br)
         }
     }
 
+    [Immutable]
     [Packet(0x00)]
     public sealed class LoginDisconnect : ISerializablePacket
     {
@@ -41,6 +44,7 @@ public void Serialize(BinaryWriter bw)
         }
     }
 
+    [Immutable]
     [Packet(0x02)]
     public sealed class LoginSuccess : ISerializablePacket
     {

src/MineCase.Protocol/Protocol/Packet.cs

@@ -4,10 +4,12 @@
 using System.Text;
 using System.Threading.Tasks;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol
 {
-    public struct UncompressedPacket
+    [Immutable]
+    public class UncompressedPacket
     {
         [SerializeAs(DataType.VarInt)]
         public uint Length;
@@ -34,7 +36,7 @@ public async Task SerializeAsync(Stream stream)
 
         public static async Task<UncompressedPacket> DeserializeAsync(Stream stream)
         {
-            var packet = default(UncompressedPacket);
+            var packet = new UncompressedPacket();
             int packetIdLen;
             using (var br = new BinaryReader(stream, Encoding.UTF8, true))
             {
@@ -48,7 +50,8 @@ public static async Task<UncompressedPacket> DeserializeAsync(Stream stream)
         }
     }
 
-    public struct CompressedPacket
+    [Immutable]
+    public class CompressedPacket
     {
         [SerializeAs(DataType.VarInt)]
         public uint PacketLength;
@@ -75,7 +78,7 @@ public async Task SerializeAsync(Stream stream)
 
         public static async Task<CompressedPacket> DeserializeAsync(Stream stream)
         {
-            var packet = default(CompressedPacket);
+            var packet = new CompressedPacket();
             int dataLengthLen;
             using (var br = new BinaryReader(stream, Encoding.UTF8, true))
             {

src/MineCase.Protocol/Protocol/Play/ChatMessage.cs

@@ -4,9 +4,11 @@
 using System.Text;
 using MineCase.Formats;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Play
 {
+    [Immutable]
     [Packet(0x03)]
     public sealed class ServerboundChatMessage
     {
@@ -23,6 +25,7 @@ public static ServerboundChatMessage Deserialize(BinaryReader br)
     }
 
     // TODO
+    [Immutable]
     [Packet(0x0F)]
     public sealed class ClientboundChatMessage : ISerializablePacket
     {

src/MineCase.Protocol/Protocol/Play/ChunkData.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Play
 {
+    [Immutable]
     [Packet(0x20)]
     public sealed class ChunkData : ISerializablePacket
     {
@@ -59,6 +61,7 @@ public void Serialize(BinaryWriter bw)
         }
     }
 
+    [Immutable]
     public sealed class ChunkSection : ISerializablePacket
     {
         [SerializeAs(DataType.Byte)]

src/MineCase.Protocol/Protocol/Play/ClientSettings.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Play
 {
+    [Immutable]
     [Packet(0x05)]
     public sealed class ClientSettings
     {

src/MineCase.Protocol/Protocol/Play/ConfirmTransaction.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Play
 {
+    [Immutable]
     [Packet(0x06)]
     public sealed class ServerboundConfirmTransaction
     {

src/MineCase.Protocol/Protocol/Play/HeldItemChange.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Play
 {
+    [Immutable]
     [Packet(0x1A)]
     public sealed class ServerboundHeldItemChange
     {

src/MineCase.Protocol/Protocol/Play/JoinGame.cs

@@ -3,9 +3,11 @@
 using System.IO;
 using System.Text;
 using MineCase.Serialization;
+using Orleans.Concurrency;
 
 namespace MineCase.Protocol.Play
 {
+    [Immutable]
     [Packet(0x23)]
     public class JoinGame : ISerializablePacket
     {