Skip to content

Commit 4f4f1fe

Browse files
author
agile.zhou
committed
Merge branch 'master' into publish
2 parents 5ee35c5 + dcb4a44 commit 4f4f1fe

File tree

3 files changed

+34
-10
lines changed

3 files changed

+34
-10
lines changed

src/AgileConfig.Server.Apisite/AgileConfig.Server.Apisite.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
<PropertyGroup>
44
<TargetFramework>net10.0</TargetFramework>
55
<AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel>
6-
<AssemblyVersion>1.11.1</AssemblyVersion>
7-
<Version>1.11.1</Version>
8-
<PackageVersion>1.11.1</PackageVersion>
6+
<AssemblyVersion>1.11.2</AssemblyVersion>
7+
<Version>1.11.2</Version>
8+
<PackageVersion>1.11.2</PackageVersion>
99
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
10-
<FileVersion>1.11.1</FileVersion>
10+
<FileVersion>1.11.2</FileVersion>
1111
<Authors>kklldog</Authors>
1212
<Company>kklldog</Company>
1313
</PropertyGroup>

src/AgileConfig.Server.Service/ConfigService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,12 @@ public async Task<Config> GetByAppIdKeyEnv(string appId, string group, string ke
151151
if (string.IsNullOrEmpty(group))
152152
{
153153
Expression<Func<Config, bool>> exp1 = c => c.Group == "" || c.Group == null;
154-
exp.And(exp1);
154+
exp = exp.And(exp1);
155155
}
156156
else
157157
{
158158
Expression<Func<Config, bool>> exp1 = c => c.Group == group;
159-
exp.And(exp1);
159+
exp = exp.And(exp1);
160160
}
161161

162162
using var repository = _configRepositoryAccessor(env);

test/AgileConfig.Server.ServiceTests/sqlite/ConfigServiceTests.cs

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -318,10 +318,9 @@ public async Task GetByAppIdKeyTest()
318318
ClearData();
319319

320320
var env = "DEV";
321-
var id = Guid.NewGuid().ToString();
322321
var appid1 = Guid.NewGuid().ToString();
323322
var appid2 = Guid.NewGuid().ToString();
324-
323+
var id = Guid.NewGuid().ToString();
325324
var source = new Config
326325
{
327326
AppId = appid1,
@@ -366,18 +365,43 @@ public async Task GetByAppIdKeyTest()
366365
OnlineStatus = OnlineStatus.Online,
367366
Env = env
368367
};
368+
var id3 = Guid.NewGuid().ToString();
369+
var source3 = new Config
370+
{
371+
AppId = appid1,
372+
Id = id3,
373+
Group = "",
374+
Key = "k",
375+
Value = "v",
376+
Description = "d1",
377+
CreateTime = DateTime.Now,
378+
UpdateTime = DateTime.Now,
379+
Status = ConfigStatus.Enabled,
380+
OnlineStatus = OnlineStatus.Online,
381+
Env = env
382+
};
369383
var result = await _service.AddAsync(source, env);
370384
Assert.IsTrue(result);
371385
var result1 = await _service.AddAsync(source1, env);
372386
Assert.IsTrue(result1);
373387
var result2 = await _service.AddAsync(source2, env);
374388
Assert.IsTrue(result2);
389+
var result3 = await _service.AddAsync(source3, env);
390+
Assert.IsTrue(result3);
375391

376392
var config = await _service.GetByAppIdKeyEnv(appid1, "g", "k", env);
377393
Assert.IsNotNull(config);
394+
Assert.AreEqual("g", config.Group);
395+
Assert.AreEqual("k", config.Key);
396+
Assert.AreEqual("v", config.Value);
397+
var config1 = await _service.GetByAppIdKeyEnv(appid1, "", "k", env);
398+
Assert.IsNotNull(config1);
399+
Assert.AreEqual("", config1.Group);
400+
Assert.AreEqual("k", config1.Key);
401+
Assert.AreEqual("v", config1.Value);
378402

379-
var config1 = await _service.GetByAppIdKeyEnv(appid2, "g", "k", env);
380-
Assert.IsNull(config1);
403+
var config2 = await _service.GetByAppIdKeyEnv(appid2, "g", "k", env);
404+
Assert.IsNull(config2);
381405
}
382406

383407
[TestMethod]

0 commit comments

Comments
 (0)