Skip to content

Commit b29dc6b

Browse files
committed
fix scope for some services to pass the Ms DI's validation
1 parent 6a37bcc commit b29dc6b

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

src/AspectCore.Extensions.DependencyInjection/ServiceCollectionExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ internal static IServiceCollection TryAddDynamicProxyServices(this IServiceColle
5353
services.TryAddScoped<IAspectActivatorFactory, AspectActivatorFactory>();
5454
services.TryAddScoped<IProxyGenerator, ProxyGenerator>();
5555
services.TryAddScoped<IParameterInterceptorSelector, ParameterInterceptorSelector>();
56+
services.TryAddScoped<IInterceptorCollector, InterceptorCollector>();
57+
services.TryAddScoped<IAspectBuilderFactory, AspectBuilderFactory>();
5658

57-
services.TryAddSingleton<IInterceptorCollector, InterceptorCollector>();
5859
services.TryAddSingleton<IAspectValidatorBuilder, AspectValidatorBuilder>();
59-
services.TryAddSingleton<IAspectBuilderFactory, AspectBuilderFactory>();
6060
services.TryAddSingleton<IProxyTypeGenerator, ProxyTypeGenerator>();
6161
services.TryAddSingleton<IAspectCachingProvider, AspectCachingProvider>();
6262

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
using Microsoft.Extensions.DependencyInjection;
2+
using Xunit;
3+
4+
namespace AspectCore.Extensions.DependencyInjection.Test;
5+
6+
public class ServiceCollectionBuildExtensionsTests
7+
{
8+
[Fact]
9+
public void BuildDynamicProxyProvider_Validate()
10+
{
11+
var services = new ServiceCollection();
12+
var provider = services.BuildDynamicProxyProvider(new ServiceProviderOptions { ValidateOnBuild = true, ValidateScopes = true });
13+
Assert.NotNull(provider);
14+
}
15+
}

0 commit comments

Comments
 (0)