fix reflect constructor error when ValueTupe's elements more than 7 (#307)

* fix: create instance of tuple/valuetuple exception when parameters number more than 7

* fix: add valuetuple more than 7 elements unit test

Author: MarsonShine

sample/AspectCore.Extensions.DependencyInjection.ConsoleSample/Program.cs

@@ -1,4 +1,6 @@
 using System;
+using System.Linq;
+using System.Reflection;
 using AspectCore.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection;
 
@@ -13,11 +15,11 @@ static void Main(string[] args)
             services.AddTransient<ILogger, ConsoleLogger>();
             services.AddTransient<ISampleService, SampleService>();
             var serviceProvider = services.BuildServiceContextProvider();
-//            var container = services.ToServiceContext();
-//            container.AddType<ILogger, ConsoleLogger>();
-//            container.AddType<ISampleService, SampleService>();
-//            var serviceResolver = container.Build();
-//            var sampleService = serviceResolver.Resolve<ISampleService>();
+            //            var container = services.ToServiceContext();
+            //            container.AddType<ILogger, ConsoleLogger>();
+            //            container.AddType<ISampleService, SampleService>();
+            //            var serviceResolver = container.Build();
+            //            var sampleService = serviceResolver.Resolve<ISampleService>();
             var sampleService = serviceProvider.GetService<ISampleService>();
             sampleService.Invoke();
             Console.ReadKey();

src/AspectCore.Extensions.Reflection/Extensions/TypeExtensions.cs

@@ -2,6 +2,7 @@
 using System.Collections.Concurrent;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
 
 namespace AspectCore.Extensions.Reflection
@@ -181,5 +182,21 @@ public static bool IsNullableType(this Type type)
             return type.GetTypeInfo().IsGenericType &&
                    type.GetGenericTypeDefinition() == typeof(Nullable<>);
         }
+
+        public static bool IsTupleType(this Type type)
+        {
+            if (type is null)
+            {
+                throw new ArgumentNullException(nameof(type));
+            }
+#if NET461
+            return false;
+#elif NETSTANDARD2_0
+            return false;
+#else
+            return type.IsGenericType && typeof(ITuple).IsAssignableFrom(type.GetTypeInfo().GetGenericTypeDefinition());
+#endif
+
+        }
     }
 }

src/AspectCore.Extensions.Reflection/ParameterReflector.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 
 namespace AspectCore.Extensions.Reflection
 {
@@ -24,7 +25,11 @@ public partial class ParameterReflector : ICustomAttributeReflectorProvider
         private ParameterReflector(ParameterInfo reflectionInfo)
         {
             _reflectionInfo = reflectionInfo ?? throw new ArgumentNullException(nameof(reflectionInfo));
-            _customAttributeReflectors = _reflectionInfo.CustomAttributes.Select(data => CustomAttributeReflector.Create(data)).ToArray();
+
+            if (!reflectionInfo.ParameterType.IsTupleType())
+            {
+                _customAttributeReflectors = _reflectionInfo.CustomAttributes.Select(data => CustomAttributeReflector.Create(data)).ToArray();
+            }
             HasDeflautValue = reflectionInfo.HasDefaultValueByAttributes();
             if (HasDeflautValue)
             {

tests/AspectCore.Extensions.DependencyInjection.Test/Issues/ValueTupleMorethan7ElementsTests.cs

@@ -0,0 +1,83 @@
+using Microsoft.Extensions.DependencyInjection;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace AspectCore.Extensions.DependencyInjection.Test.Issues
+{
+    // https://github.com/dotnetcore/AspectCore-Framework/issues/305
+    public class ValueTupleMorethan7ElementsTests
+    {
+        [Fact]
+        public void ValueTupleMorethan7Elements_Constructor_Test()
+        {
+            var services = new ServiceCollection();
+            services.AddScoped<ITestService, TestService>();
+            var serviceProvider = services.BuildServiceContextProvider();
+            var testService = serviceProvider.GetService<ITestService>();
+            Assert.NotNull(testService);
+
+            var (a, b, c, d, e, f, g, h) = testService.Wrap(("a", "b", "c", "d", "e", "f", "g", "h"));
+            Assert.Equal("a", a);
+            Assert.Equal("b", b);
+            Assert.Equal("c", c);
+            Assert.Equal("d", d);
+            Assert.Equal("e", e);
+            Assert.Equal("f", f);
+            Assert.Equal("g", g);
+            Assert.Equal("h", h);
+        }
+        public interface ITestService
+        {
+            //void Update((string, string, string, string, string, string, string) tupleKey);
+            void Update((string a, string b, string c, string d, string e, string f, string g, string h) tupleKey);
+            (string a, string b, string c, string d, string e, string f, string g, string h) Wrap((string a, string b, string c, string d, string e, string f, string g, string h) tupleKey);
+            //void Update2((string a, string b, string c, string d, string e, string f, string g) tupleKey);
+            //void Update3((string a, string b, string c, string d, string e, string f, string g, string h, (string i, string j)) tupleKey);
+        }
+
+        public class TestService : ITestService
+        {
+            //public void Update((string, string, string, string, string, string, string) tupleKey)
+            //{
+
+            //}
+            public void Update((string a, string b, string c, string d, string e, string f, string g, string h) tupleKey)
+            {
+            }
+
+            public (string a, string b, string c, string d, string e, string f, string g, string h) Wrap((string a, string b, string c, string d, string e, string f, string g, string h) tupleKey)
+            {
+                return tupleKey;
+            }
+
+            //public void Update2((string a, string b, string c, string d, string e, string f, string g) tupleKey)
+            //{
+
+            //}
+
+            //public void Update3((string a, string b, string c, string d, string e, string f, string g, string h, (string i, string j)) tupleKey)
+            //{
+
+            //}
+
+            //public void Update6((string a, string b, string c, string d, string e, string f, string g, (string h, string i, string j) ff) tupleKey)
+            //{
+
+            //}
+
+            //public void Update4((string, string, string, string, string, string, string) tupleKey)
+            //{
+
+            //}
+
+            //public void Update5((string, string, string, string, string, string, string, string, string) tupleKey)
+            //{
+
+            //}
+        }
+    }
+}