Skip to content

Commit 16b02fe

Browse files
authored
test(Upload): improve code coverage (#6168)
* refactor: 获得文件扩展名方法 * test: 测试单元测试 * Revert "test: 测试单元测试" This reverts commit 83be2fa. * chore: 更新 codecov action 版本 * refactor: 更改可为空检查 * test: 增加 Flags 参数 * chore: 更新 action 版本 * revert: 恢复代码 * test: 更新单元测试
1 parent d139e8c commit 16b02fe

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.github/workflows/auto-pull-request-checks.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
dotnet test test/UnitTest --collect:"XPlat Code Coverage"
2626
2727
- name: Upload to Codecov
28-
uses: codecov/codecov-action@v4
28+
uses: codecov/codecov-action@v5
2929
with:
3030
token: ${{ secrets.CODECOV_TOKEN }}
31+
flags: BB

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
dotnet test test/UnitTest --collect:"XPlat Code Coverage"
3333
3434
- name: Upload to Codecov
35-
uses: codecov/codecov-action@v4
35+
uses: codecov/codecov-action@v5
3636
with:
3737
token: ${{ secrets.CODECOV_TOKEN }}
3838

src/BootstrapBlazor/Components/Upload/UploadPreviewList.razor.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,17 +252,17 @@ private async Task OnClickCancel(UploadFile item)
252252
private string? GetFileFormatClassString(UploadFile item)
253253
{
254254
var builder = CssBuilder.Default("file-icon");
255-
var fileExtension = Path.GetExtension(item.OriginFileName ?? item.FileName);
255+
var fileExtension = Path.GetExtension(item.GetFileName());
256256
if (!string.IsNullOrEmpty(fileExtension))
257257
{
258258
fileExtension = fileExtension.ToLowerInvariant();
259+
var icon = OnGetFileFormat?.Invoke(fileExtension) ?? GetFileExtensions(fileExtension);
260+
builder.AddClass(icon);
259261
}
260-
var icon = OnGetFileFormat?.Invoke(fileExtension) ?? GetFileExtensions(fileExtension);
261-
builder.AddClass(icon);
262262
return builder.Build();
263263
}
264264

265-
private string? GetFileExtensions(string? fileExtension) => fileExtension switch
265+
private string? GetFileExtensions(string fileExtension) => fileExtension switch
266266
{
267267
".csv" or ".xls" or ".xlsx" => FileIconExcel,
268268
".doc" or ".docx" or ".dot" or ".dotx" => FileIconDocx,

test/UnitTest/Components/UploadButtonTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ public void ButtonUpload_OnGetFileFormat_Ok()
362362
new() { FileName = "1.doc" },
363363
new() { FileName = "1.docx" },
364364
new() { FileName = "1.dot" },
365+
new() { FileName = "1.dotx" },
365366
new() { FileName = "1.ppt" },
366367
new() { FileName = "1.pptx" },
367368
new() { FileName = "1.wav" },
@@ -397,7 +398,6 @@ public void ButtonUpload_OnGetFileFormat_Ok()
397398
cut.Contains("fa-file-archive");
398399
cut.Contains("fa-file-text");
399400
cut.Contains("fa-file-image");
400-
cut.Contains("fa-file-archive");
401401
cut.Contains("fa-file");
402402

403403
cut.SetParametersAndRender(pb =>

0 commit comments

Comments
 (0)