Skip to content

Commit 419da1e

Browse files
committed
refactor: 移除 IsFixedSearch 参数
1 parent aa51deb commit 419da1e

File tree

10 files changed

+22
-67
lines changed

10 files changed

+22
-67
lines changed

src/BootstrapBlazor/Components/EditorForm/IEditorItem.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ public interface IEditorItem : ILookup
8989
/// <summary>
9090
/// Gets or sets whether to allow fixed search box within dropdown. Default is false.
9191
/// </summary>
92+
[Obsolete("已弃用 Departur")]
9293
bool IsFixedSearchWhenSelect { get; set; }
9394

9495
/// <summary>

src/BootstrapBlazor/Components/Select/MultiSelect.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
{
5454
<span class="@ClearClassString" @onclick="OnClearValue"><i class="@ClearableIcon"></i></span>
5555
}
56-
<div class="@MultipleDropdownMenuClassString">
56+
<div class="@DropdownMenuClassString">
5757
@if (ShowSearch)
5858
{
5959
<div class="dropdown-menu-search">

src/BootstrapBlazor/Components/Select/MultiSelect.razor.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public partial class MultiSelect<TValue>
2020
.AddClass("is-clearable", IsClearable)
2121
.Build();
2222

23-
private string? MultipleDropdownMenuClassString => CssBuilder.Default(DropdownMenuClassString)
23+
private string? DropdownMenuClassString => CssBuilder.Default("dropdown-menu")
2424
.AddClass("is-fixed-toolbar", ShowToolbar)
2525
.Build();
2626

@@ -295,12 +295,6 @@ protected override List<SelectedItem> GetRowsByItems()
295295
return items;
296296
}
297297

298-
/// <summary>
299-
/// <inheritdoc/>
300-
/// </summary>
301-
/// <returns></returns>
302-
protected override bool CheckFixedSearch() => ShowToolbar ? true : base.CheckFixedSearch();
303-
304298
/// <summary>
305299
/// 客户端回车回调方法
306300
/// </summary>

src/BootstrapBlazor/Components/Select/MultiSelect.razor.scss

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,17 +122,16 @@
122122
.dropdown-menu {
123123
&.is-fixed-toolbar {
124124
--bb-dropdown-max-height: 330px;
125+
--bb-dropdown-toolbar-height: 38px;
125126

126127
.dropdown-menu-body {
127-
max-height: calc(var(--bb-dropdown-max-height) - 48px);
128-
overflow: auto;
128+
max-height: calc(var(--bb-dropdown-max-height) - var(--bb-dropdown-toolbar-height));
129129
}
130130
}
131131

132132
&.is-fixed-search.is-fixed-toolbar {
133133
.dropdown-menu-body {
134-
max-height: calc(var(--bb-dropdown-max-height) - 117px);
135-
overflow: auto;
134+
max-height: calc(var(--bb-dropdown-max-height) - var(--bb-select-search-height) - var(--bb-dropdown-toolbar-height));
136135
}
137136
}
138137

src/BootstrapBlazor/Components/Select/Select.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
{
3131
<span class="@ClearClassString" @onclick="OnClearValue"><i class="@ClearIcon"></i></span>
3232
}
33-
<div class="@DropdownMenuClassString">
33+
<div class="dropdown-menu">
3434
@if (ShowSearch)
3535
{
3636
<div class="dropdown-menu-search">

src/BootstrapBlazor/Components/Select/Select.razor.scss

Lines changed: 13 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,11 @@
77
--bb-select-focus-shadow: #{$bb-select-focus-shadow};
88
--bb-select-padding-right: #{$bb-select-padding-right};
99
--bb-select-padding: #{$bb-select-padding};
10-
--bb-select-search-padding: #{$bb-select-search-padding};
11-
--bb-select-search-margin-bottom: #{$bb-select-search-margin-bottom};
12-
--bb-select-search-border-color: #{$bb-select-search-border-color};
13-
--bb-select-search-padding-right: #{$bb-select-search-padding-right};
14-
--bb-select-search-icon-color: #{$bb-select-search-icon-color};
15-
--bb-select-search-icon-right: #{$bb-select-search-icon-right};
16-
--bb-select-search-icon-top: #{$bb-select-search-icon-top};
17-
--bb-select-search-height: #{$bb-select-search-height};
1810
--bb-select-append-width: #{$bb-select-append-width};
1911
--bb-select-append-color: #{$bb-select-append-color};
2012
}
2113

2214
.select:not(.cascade) .dropdown-menu {
23-
overflow-x: hidden;
2415
width: 100%;
2516
}
2617

@@ -48,22 +39,6 @@
4839
background-color: var(--bs-secondary-bg);
4940
}
5041

51-
.dropdown-menu {
52-
--bs-dropdown-border-radius: var(--bs-border-radius);
53-
overflow: auto;
54-
max-height: var(--bb-dropdown-max-height);
55-
}
56-
57-
.dropdown-menu .dropdown-virtual {
58-
overflow-y: auto;
59-
margin: calc(0px - var(--bs-dropdown-padding-y)) var(--bs-dropdown-padding-x);
60-
padding: var(--bs-dropdown-padding-y) var(--bs-dropdown-padding-x);
61-
}
62-
63-
.dropdown-menu .search + .dropdown-virtual {
64-
max-height: calc(var(--bb-dropdown-max-height) - var(--bb-select-search-height));
65-
}
66-
6742
.dropdown-item {
6843
cursor: pointer;
6944
}
@@ -209,12 +184,14 @@
209184
}
210185

211186
.dropdown-menu {
212-
&.is-fixed-search {
213-
.dropdown-menu-body {
214-
max-height: calc(var(--bb-dropdown-max-height) - 76px);
215-
overflow: auto;
216-
}
217-
}
187+
--bb-select-search-padding: #{$bb-select-search-padding};
188+
--bb-select-search-margin-bottom: #{$bb-select-search-margin-bottom};
189+
--bb-select-search-padding-right: #{$bb-select-search-padding-right};
190+
--bb-select-search-border-color: #{$bb-select-search-border-color};
191+
--bb-select-search-icon-color: #{$bb-select-search-icon-color};
192+
--bb-select-search-icon-right: #{$bb-select-search-icon-right};
193+
--bb-select-search-icon-top: #{$bb-select-search-icon-top};
194+
--bb-select-search-height: #{$bb-select-search-height};
218195

219196
.dropdown-menu-search {
220197
padding: var(--bb-select-search-padding);
@@ -237,6 +214,11 @@
237214
}
238215
}
239216

217+
.dropdown-menu-body {
218+
max-height: var(--bb-dropdown-max-height);
219+
overflow: auto;
220+
}
221+
240222
.search-text {
241223
padding-inline-end: var(--bb-select-search-padding-right);
242224
}

src/BootstrapBlazor/Components/Select/SelectBase.cs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ public abstract class SelectBase<TValue> : PopoverSelectBase<TValue>
2323
[Parameter]
2424
public bool ShowSearch { get; set; }
2525

26-
/// <summary>
27-
/// Gets or sets whether the search bar in the dropdown is fixed. Default is false.
28-
/// </summary>
29-
[Parameter]
30-
public bool IsFixedSearch { get; set; }
31-
3226
/// <summary>
3327
/// Gets or sets the search icon.
3428
/// </summary>
@@ -168,13 +162,6 @@ public abstract class SelectBase<TValue> : PopoverSelectBase<TValue>
168162
.AddClass($"text-danger", IsValid.HasValue && !IsValid.Value)
169163
.Build();
170164

171-
/// <summary>
172-
/// Gets the dropdown menu class string.
173-
/// </summary>
174-
protected string? DropdownMenuClassString => CssBuilder.Default("dropdown-menu shadow")
175-
.AddClass("is-fixed-search", CheckFixedSearch())
176-
.Build();
177-
178165
/// <summary>
179166
/// Gets the clear icon class string.
180167
/// </summary>
@@ -243,10 +230,4 @@ protected virtual async Task OnClearValue()
243230
}
244231
CurrentValue = default;
245232
}
246-
247-
/// <summary>
248-
/// Gets whether to show the search box.
249-
/// </summary>
250-
/// <returns></returns>
251-
protected virtual bool CheckFixedSearch() => ShowSearch && IsFixedSearch;
252233
}

src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
{
3131
<span class="@ClearClassString" @onclick="OnClearValue"><i class="@ClearIcon"></i></span>
3232
}
33-
<div class="@DropdownMenuClassString">
33+
<div class="dropdown-menu">
3434
@if (ShowSearch)
3535
{
3636
<div class="dropdown-menu-search">

src/BootstrapBlazor/Utils/Utility.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,6 @@ public static void CreateComponentByFieldType(this RenderTreeBuilder builder, Co
532532
if (item.IsLookup() && item.Items == null)
533533
{
534534
builder.AddAttribute(110, nameof(Select<SelectedItem>.ShowSearch), item.ShowSearchWhenSelect);
535-
builder.AddAttribute(111, nameof(Select<SelectedItem>.IsFixedSearch), item.IsFixedSearchWhenSelect);
536535
builder.AddAttribute(115, nameof(Select<SelectedItem>.Items), item.Lookup);
537536
builder.AddAttribute(120, nameof(Select<SelectedItem>.LookupService), lookupService);
538537
builder.AddAttribute(121, nameof(Select<SelectedItem>.LookupServiceKey), item.LookupServiceKey);
@@ -545,7 +544,6 @@ public static void CreateComponentByFieldType(this RenderTreeBuilder builder, Co
545544
{
546545
builder.AddAttribute(140, nameof(Select<SelectedItem>.Items), item.Items.Clone());
547546
builder.AddAttribute(150, nameof(Select<SelectedItem>.ShowSearch), item.ShowSearchWhenSelect);
548-
builder.AddAttribute(151, nameof(Select<SelectedItem>.IsFixedSearch), item.IsFixedSearchWhenSelect);
549547
}
550548

551549
// 设置 SkipValidate 参数

src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ $bb-select-search-padding-right: 30px;
517517
$bb-select-search-icon-color: var(--bb-select-search-border-color);
518518
$bb-select-search-icon-right: 20px;
519519
$bb-select-search-icon-top: 17px;
520-
$bb-select-search-height: 60px;
520+
$bb-select-search-height: 52px;
521521
$bb-select-append-width: 30px;
522522
$bb-select-append-color: #c0c4cc;
523523

0 commit comments

Comments
 (0)