Skip to content

Conversation

@kimdiego2098
Copy link
Collaborator

@kimdiego2098 kimdiego2098 commented Oct 12, 2024

improve create tab item from url performance

Summary of the changes (Less than 80 chars)

创建TabItem时不需要渲染TabItem组件

Description

fixes #4450

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

@bb-auto
Copy link

bb-auto bot commented Oct 12, 2024

Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang October 12, 2024 15:12
@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (14871c4) to head (9224411).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4445   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          613       613           
  Lines        26612     26613    +1     
  Branches      3879      3879           
=========================================
+ Hits         26612     26613    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang changed the title fix(tab): 创建TabItem时不需要渲染TabItem组件 perf(Tab): improve create tab item from url performance Oct 13, 2024
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 13, 2024
@bb-auto bb-auto bot added this to the v8.10.0 milestone Oct 13, 2024
ArgoZhang
ArgoZhang previously approved these changes Oct 13, 2024
ArgoZhang
ArgoZhang previously approved these changes Oct 13, 2024
@ArgoZhang ArgoZhang merged commit 71ee1ab into main Oct 13, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the tab_dev branch October 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(Tab): improve create tab item from url performance

3 participants