Skip to content

Conversation

@j4587698
Copy link
Collaborator

@j4587698 j4587698 commented Oct 23, 2024

support SelectedItem generic value

Select支持TValue

Description

fixes #4497

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

@bb-auto
Copy link

bb-auto bot commented Oct 23, 2024

Thanks for your PR, @j4587698. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang October 23, 2024 12:07
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 23, 2024
@bb-auto bb-auto bot added this to the v8.10.0 milestone Oct 23, 2024
@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e94371a) to head (1e91070).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          630       631    +1     
  Lines        27011     27051   +40     
  Branches      3917      3924    +7     
=========================================
+ Hits         27011     27051   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang
ArgoZhang previously approved these changes Oct 24, 2024
@ArgoZhang ArgoZhang changed the title Select支持TValue feat(Select): support SelectedItem<TValue> generic value Oct 24, 2024
@j4587698
Copy link
Collaborator Author

@dotnet-policy-service agree

@ArgoZhang ArgoZhang merged commit 0b24a25 into main Oct 24, 2024
6 checks passed
@ArgoZhang ArgoZhang deleted the demo-autofill branch October 24, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(SelectedItem): 希望选项值可以支持 TValue 而不仅仅是文本

3 participants