Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 24, 2024

add OnBlurAsync parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4528

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add an OnBlurAsync parameter to the DateTimePicker component to support asynchronous operations on blur events and include a corresponding unit test to ensure its functionality.

New Features:

  • Introduce an OnBlurAsync parameter to the DateTimePicker component, allowing asynchronous operations to be triggered when the component loses focus.

Tests:

  • Add a unit test to verify the functionality of the OnBlurAsync parameter in the DateTimePicker component.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2024

Reviewer's Guide by Sourcery

This PR adds a new OnBlurAsync parameter to the DateTimePicker component, allowing users to handle blur events asynchronously. The implementation includes adding the parameter property, implementing the blur event handler, and adding corresponding unit tests.

Sequence diagram for OnBlurAsync event handling

sequenceDiagram
    participant User as User
    participant DateTimePicker as DateTimePicker Component
    participant Handler as OnBlurAsync Handler

    User->>DateTimePicker: Blur input field
    DateTimePicker->>DateTimePicker: OnBlur()
    alt OnBlurAsync is set
        DateTimePicker->>Handler: OnBlurAsync(Value)
        Handler-->>DateTimePicker: Task Completed
    end
Loading

Class diagram for DateTimePicker changes

classDiagram
    class DateTimePicker {
        +bool DisplayDisabledDayAsEmpty
        +Func~TValue, Task~ OnBlurAsync
        -IStringLocalizer~DateTimePicker~ Localizer
        -string? ReadonlyString
        +Task OnBlur()
    }
    note for DateTimePicker "Added OnBlurAsync parameter and OnBlur method"
Loading

File-Level Changes

Change Details Files
Added new OnBlurAsync parameter and handler
  • Added OnBlurAsync parameter property of type Func<TValue, Task>
  • Implemented protected virtual OnBlur method to handle blur events
  • Added onblur event binding to the input element
src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.cs
src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor
Added unit test coverage for OnBlurAsync functionality
  • Created test case to verify OnBlurAsync callback is triggered on input blur
  • Verified blur state changes correctly when callback is executed
test/UnitTest/Components/DateTimePickerTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4528 Add OnBlurAsync parameter to DateTimePicker component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Oct 24, 2024
@bb-auto bb-auto bot added this to the v8.10.0 milestone Oct 24, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7bc5225) to head (e3b8485).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4529   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          631       631           
  Lines        27065     27072    +7     
  Branches      3927      3928    +1     
=========================================
+ Hits         27065     27072    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit cf30213 into main Oct 24, 2024
6 checks passed
@ArgoZhang ArgoZhang deleted the feat-dt branch October 24, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(DateTimePicker): add OnBlurAsync parameter

2 participants