-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Checkbox): optimize OnBeforeStateChanged callback method #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR optimizes the Checkbox component's OnBeforeStateChanged callback by introducing a data attribute-based approach to conditionally trigger the callback, replacing the previous implementation that always invoked the JavaScript initialization. Sequence diagram for optimized OnBeforeStateChanged callbacksequenceDiagram
actor User
participant Checkbox
participant JavaScript
User->>Checkbox: Click on Checkbox
Checkbox->>JavaScript: init(id, invoke, { Callback })
JavaScript->>Checkbox: Check data-bb-trigger-before attribute
alt Attribute is 'true'
JavaScript->>Checkbox: invokeMethodAsync(options.callback)
else Attribute is not 'true'
JavaScript-->>User: No callback triggered
end
Updated class diagram for Checkbox componentclassDiagram
class Checkbox {
+bool StopPropagation
+string? TriggerBeforeValueString
+Task InvokeInitAsync()
}
note for Checkbox "TriggerBeforeValueString is a new private property to determine if the callback should be triggered."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4566 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 622 622
Lines 26937 26933 -4
Branches 3923 3923
=========================================
- Hits 26937 26933 -4 ☔ View full report in Codecov by Sentry. |
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
optimize OnBeforeStateChanged callback method
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4565
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: