-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(AjaxService): redesign AjaxService #4570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR redesigns the AjaxService by moving it from a component-based implementation to a dedicated service class. The new implementation uses JS module loading for Ajax functionality and removes the need for a separate Ajax component. Sequence diagram for AjaxService InvokeAsync methodsequenceDiagram
participant Client
participant AjaxService
participant JSModule
Client->>AjaxService: InvokeAsync(option, token)
AjaxService->>JSModule: LoadModule()
JSModule-->>AjaxService: JSModule instance
AjaxService->>JSModule: InvokeAsync("execute", token, option)
JSModule-->>AjaxService: JsonDocument?
AjaxService-->>Client: JsonDocument?
Sequence diagram for AjaxService Goto methodsequenceDiagram
participant Client
participant AjaxService
participant JSModule
Client->>AjaxService: Goto(url, token)
AjaxService->>JSModule: LoadModule()
JSModule-->>AjaxService: JSModule instance
AjaxService->>JSModule: InvokeVoidAsync("goto", token, url)
JSModule-->>AjaxService: void
Class diagram for redesigned AjaxServiceclassDiagram
class AjaxService {
+Task<JSModule> LoadModule()
+Task<JsonDocument?> InvokeAsync(AjaxOption option, CancellationToken token)
+Task Goto(string url, CancellationToken token)
-JSModule _module
}
class JSModule {
+Task<T> InvokeAsync<T>(string method, CancellationToken token, params object[] args)
+Task InvokeVoidAsync(string method, CancellationToken token, params object[] args)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template with a proper risk assessment and verification steps, as this appears to be a significant architectural change to the Ajax functionality.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
redesign AjaxService
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4569
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Redesign the AjaxService by introducing a new class to manage Ajax requests and page navigation, removing the Ajax component from the BootstrapBlazorRoot, and adding a test case for the new Goto method.
New Features:
Enhancements:
Tests: