-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix(SelectTable): validate component shoud be skip validate in search panel #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR modifies the validation behavior in the SelectTable component by ensuring that validation is skipped for search panel inputs. This is implemented by setting the SkipValidate property to true for search-related components. Class diagram for updated validation logic in SelectTable componentclassDiagram
class BootstrapInput {
+string class
+string placeholder
+EventHandler onkeyup
+string bind-Value
+bool SkipValidate
}
class Utility {
+void CreateComponentByFieldType(RenderTreeBuilder builder, ComponentType componentType, bool isSearch, IEditorItem item)
}
BootstrapInput --> Utility : uses
note for BootstrapInput "SkipValidate is set to true for search panel inputs"
note for Utility "CreateComponentByFieldType method updated to handle SkipValidate for search components"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4580 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 622 622
Lines 26858 26858
Branches 3920 3921 +1
=========================================
Hits 26858 26858 ☔ View full report in Codecov by Sentry. |
validate component shoud be skip validate in search panel
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4577
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: