Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 31, 2024

validate component shoud be skip validate in search panel

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4577

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Ensure the 'SkipValidate' attribute is set to true for the search input in the SelectTable component to prevent validation in the search panel.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

The PR modifies the validation behavior in the SelectTable component by ensuring that validation is skipped for search panel inputs. This is implemented by setting the SkipValidate property to true for search-related components.

Class diagram for updated validation logic in SelectTable component

classDiagram
    class BootstrapInput {
        +string class
        +string placeholder
        +EventHandler onkeyup
        +string bind-Value
        +bool SkipValidate
    }

    class Utility {
        +void CreateComponentByFieldType(RenderTreeBuilder builder, ComponentType componentType, bool isSearch, IEditorItem item)
    }

    BootstrapInput --> Utility : uses

    note for BootstrapInput "SkipValidate is set to true for search panel inputs"
    note for Utility "CreateComponentByFieldType method updated to handle SkipValidate for search components"
Loading

File-Level Changes

Change Details Files
Added validation skipping for search panel input components
  • Set SkipValidate property to true for the search toolbar input component
  • Modified the CreateComponentByFieldType method to consider isSearch parameter when setting SkipValidate
src/BootstrapBlazor/Components/Table/Table.razor
src/BootstrapBlazor/Utils/Utility.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4577 Prevent ValidateForm from validating search fields in SelectTable

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Oct 31, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Oct 31, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 31, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (40bea27) to head (c74c7fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          622       622           
  Lines        26858     26858           
  Branches      3920      3921    +1     
=========================================
  Hits         26858     26858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 557107b into main Oct 31, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-select-table branch October 31, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(SelectTable): ValidateForm will validate the fields with search enabled

2 participants