-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(PrintService): remove Print component #4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR removes the Print component and refactors the PrintService to use DialogService directly. The PrintService is simplified by removing inheritance from BootstrapServiceBase and instead using dependency injection for DialogService. Updated class diagram for PrintServiceclassDiagram
class PrintService {
+PrintService(DialogService dialogService)
+Task PrintAsync(DialogOption option)
}
class DialogService {
+Show(DialogOption option)
}
PrintService --> DialogService : uses
note for PrintService "Refactored to use DialogService directly and removed inheritance from BootstrapServiceBase"
Class diagram for removed Print componentclassDiagram
class Print {
-Print()
}
note for Print "This component has been removed"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete all checkboxes in the PR template to ensure proper review process
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4582 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 622 621 -1
Lines 26858 26842 -16
Branches 3921 3920 -1
=========================================
- Hits 26858 26842 -16 ☔ View full report in Codecov by Sentry. |
remove Print component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4581
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the Print component from the BootstrapBlazor project and update the PrintService to use DialogService for printing functionality.