Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 31, 2024

remove Print component

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4581

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the Print component from the BootstrapBlazor project and update the PrintService to use DialogService for printing functionality.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

The PR removes the Print component and refactors the PrintService to use DialogService directly. The PrintService is simplified by removing inheritance from BootstrapServiceBase and instead using dependency injection for DialogService.

Updated class diagram for PrintService

classDiagram
    class PrintService {
        +PrintService(DialogService dialogService)
        +Task PrintAsync(DialogOption option)
    }
    class DialogService {
        +Show(DialogOption option)
    }
    PrintService --> DialogService : uses
    note for PrintService "Refactored to use DialogService directly and removed inheritance from BootstrapServiceBase"
Loading

Class diagram for removed Print component

classDiagram
    class Print {
        -Print()
    }
    note for Print "This component has been removed"
Loading

File-Level Changes

Change Details Files
Refactored PrintService to use DialogService directly
  • Removed inheritance from BootstrapServiceBase
  • Added constructor injection for DialogService
  • Changed PrintAsync implementation to directly use dialogService.Show
src/BootstrapBlazor/Services/PrintService.cs
Removed Print component from the component hierarchy
  • Removed Print component reference from BootstrapBlazorRoot.razor
  • Deleted Print component implementation file
src/BootstrapBlazor/Components/BaseComponents/BootstrapBlazorRoot.razor
src/BootstrapBlazor/Components/Print/Print.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4581 Remove the Print component from the codebase

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Oct 31, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Oct 31, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete all checkboxes in the PR template to ensure proper review process
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (557107b) to head (00c722a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4582   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          622       621    -1     
  Lines        26858     26842   -16     
  Branches      3921      3920    -1     
=========================================
- Hits         26858     26842   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 1035c2a into main Oct 31, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-print branch October 31, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(PrintService): remove Print component

2 participants