Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 2, 2024

support RTL mode

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4470

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add support for RTL mode by updating CSS styles to use logical properties for margin and padding, ensuring compatibility with RTL layouts.

New Features:

  • Introduce support for Right-to-Left (RTL) mode across various components.

Enhancements:

  • Refactor CSS styles to use logical properties for margin and padding, improving support for RTL layouts.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR implements RTL (Right-to-Left) support by updating CSS styles to use logical properties instead of directional properties. The implementation focuses on converting margin/padding/border properties to their logical equivalents and adding RTL-specific CSS files and configurations.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Converted CSS directional properties to logical properties
  • Changed margin-left/right to margin-inline-start/end
  • Changed padding-left/right to padding-inline-start/end
  • Changed border-left/right to border-inline-start/end
  • Updated text alignment properties to support RTL
  • Converted float properties to logical values
src/BootstrapBlazor/Components/Table/Table.razor.scss
src/BootstrapBlazor/Components/Chats.razor.css
src/BootstrapBlazor/Components/Select/Select.razor.scss
src/BootstrapBlazor/Components/Logout/Logout.razor.scss
src/BootstrapBlazor/Components/Button/Button.razor.scss
Added RTL-specific stylesheets and configurations
  • Added bootstrap.rtl.min.css for RTL layout support
  • Created new rtl.css file with RTL-specific overrides
  • Added RTL CSS bundle configuration
  • Set direction:ltr for code blocks to preserve correct display
src/BootstrapBlazor/wwwroot/core/bootstrap/css/bootstrap.rtl.min.css
src/BootstrapBlazor/wwwroot/css/rtl.css
src/BootstrapBlazor/wwwroot/css/bootstrap.blazor.bundle.rtl.min.css
src/BootstrapBlazor.Server/Components/Components/Pre.razor.css

Assessment against linked issues

Issue Objective Addressed Explanation
#4470 Add RTL support for table search functionality
#4470 Add RTL support for table filter functionality
#4470 Add RTL support for table pagination

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Nov 2, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 2, 2024
@codecov
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (feda9f4) to head (ac76ad6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4597   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27383     27383           
  Branches      3919      3919           
=========================================
  Hits         27383     27383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

@dotnetcore dotnetcore deleted a comment from sourcery-ai bot Nov 2, 2024
@dotnetcore dotnetcore deleted a comment from sourcery-ai bot Nov 2, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 2, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add documentation explaining how to enable and use RTL mode, including any configuration requirements and browser compatibility notes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 36feb53 into main Nov 2, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-rtl branch November 2, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table does not fully support RTL. In Version 8.10.2

2 participants