-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Cascader): add OnBlurAsync parameter #4599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds a new OnBlurAsync parameter to the Cascader component, allowing users to handle blur events asynchronously. The implementation includes adding the parameter property, implementing the blur event handler, and adding unit tests to verify the functionality. Sequence diagram for OnBlurAsync event handlingsequenceDiagram
participant User
participant Cascader
participant OnBlurAsyncHandler
User->>Cascader: Blur input
Cascader->>Cascader: OnBlur()
Cascader->>OnBlurAsyncHandler: OnBlurAsync(Value)
OnBlurAsyncHandler-->>Cascader: Task Completed
Cascader-->>User: Blur event handled
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please enhance the PR description to explain the motivation and use cases for adding the OnBlurAsync parameter. This will help with future maintenance.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4599 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27383 27390 +7
Branches 3919 3920 +1
=========================================
+ Hits 27383 27390 +7 ☔ View full report in Codecov by Sentry. |
add OnBlurAsync parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4598
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add the OnBlurAsync parameter to the Cascader component to support asynchronous operations on blur events and include a corresponding unit test to ensure its functionality.
New Features:
Tests: