-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Table): add DisableDelete/EditButtonCallback Parameter #4603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds new callback parameters to the Table component that allow conditional disabling of Edit and Delete buttons. The implementation includes new parameters in the Table component and corresponding unit tests to verify the functionality. The changes also include an update to the Docker configuration to use .NET 9.0. Sequence diagram for DisableEditButtonCallbacksequenceDiagram
actor User
participant Table
participant Button
User->>Table: Select a row
Table->>Button: Check DisableEditButtonCallback
alt Callback returns true
Button->>User: Edit button is disabled
else Callback returns false
Button->>User: Edit button is enabled
end
Sequence diagram for DisableDeleteButtonCallbacksequenceDiagram
actor User
participant Table
participant Button
User->>Table: Select a row
Table->>Button: Check DisableDeleteButtonCallback
alt Callback returns true
Button->>User: Delete button is disabled
else Callback returns false
Button->>User: Delete button is enabled
end
Class diagram for updated Table componentclassDiagram
class Table {
+Func<List<TItem>, bool> DisableDeleteButtonCallback
+Func<List<TItem>, bool> DisableEditButtonCallback
+bool GetEditButtonStatus()
+bool GetDeleteButtonStatus()
}
note for Table "New callback parameters added for disabling buttons conditionally"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please separate the .NET 9.0 upgrade in Dockerfile into a separate PR. Infrastructure changes should be reviewed independently from feature changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27365 27367 +2
Branches 3914 3914
=========================================
+ Hits 27365 27367 +2 ☔ View full report in Codecov by Sentry. |
add DisableDelete/EditButtonCallback Parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4602
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add new parameters to the Table component to allow conditional disabling of delete and edit buttons, update the Dockerfile to use .NET 9.0, and include tests for the new functionality.
New Features:
Enhancements:
Build:
Tests: