-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix(Table): throw exception when click delete button in table row #4625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR modifies the timeout delay in the PopConfirmButton component's initialization logic, increasing it from 50ms to 200ms to address an issue with the delete button in table rows. Sequence diagram for PopConfirmButton initializationsequenceDiagram
participant User
participant Table
participant PopConfirmButton
User->>Table: Click delete button
Table->>PopConfirmButton: Initialize with delay
PopConfirmButton-->>Table: Wait for 200ms
PopConfirmButton-->>User: Show confirmation popover
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title and description don't match the actual code changes. Please update them to reflect that this PR adjusts a popover timeout value, not adding exception handling.
- Please provide explanation for why the timeout needed to be increased from 50ms to 200ms and what specific issue this resolves.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4625 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27381 27381
Branches 3914 3914
=========================================
Hits 27381 27381 ☔ View full report in Codecov by Sentry. |
throw exception when click delete button in table row
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4621
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: