fix(JsonStringLocalizer): add type check prevent endless loop

[izanhzh]

fix: #4652

在单元测试中我增加了一个ValidateFixEndlessLoop方法，撤销掉我的代码调整，运行这个单元测试即可重现死循环问题

[bb-auto]

Thanks for your PR, @izanhzh. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes an endless loop issue in the JsonStringLocalizer by adding a type check to prevent recursive calls. The implementation includes new test cases to verify the fix and modifications to the localizer's string retrieval logic.

Sequence diagram for string retrieval in JsonStringLocalizer

sequenceDiagram
    participant Client
    participant JsonStringLocalizer
    participant Utility
    participant Localizer
    Client->>JsonStringLocalizer: Request string
    JsonStringLocalizer->>Utility: GetStringLocalizerFromService
    Utility-->>JsonStringLocalizer: Return Localizer
    JsonStringLocalizer->>JsonStringLocalizer: Check if Localizer is JsonStringLocalizer
    alt Localizer is not JsonStringLocalizer
        JsonStringLocalizer->>Localizer: GetLocalizerValueFromCache
        Localizer-->>JsonStringLocalizer: Return value
    else Localizer is JsonStringLocalizer
        JsonStringLocalizer-->>Client: Return null or default
    end

Loading

Class diagram for JsonStringLocalizer and related classes

classDiagram
    class JsonStringLocalizer {
        - string? ret
        + LocalizedString this[string name]
        + IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures)
    }
    class MockLocalizerFactory {
        + IStringLocalizer Create(Type resourceSource)
        + IStringLocalizer Create(string baseName, string location)
    }
    class MockLocalizerFactory2 {
        - IServiceProvider _serviceProvider
        + MockLocalizerFactory2(IServiceProvider serviceProvider)
        + IStringLocalizer Create(Type resourceSource)
        + IStringLocalizer Create(string baseName, string location)
    }
    class MockStringLocalizer {
        + LocalizedString this[string name]
    }
    JsonStringLocalizer --> MockLocalizerFactory
    JsonStringLocalizer --> MockLocalizerFactory2
    MockLocalizerFactory2 --> IServiceProvider
    MockLocalizerFactory2 --> MockLocalizerFactory
    MockLocalizerFactory --> MockStringLocalizer
    MockLocalizerFactory2 --> MockStringLocalizer

Loading

File-Level Changes

Change	Details	Files
Added type check to prevent recursive calls in string localization	Added condition to check if localizer is not JsonStringLocalizer type Modified string retrieval logic in indexer method Updated GetAllStrings method with the same type check	src/BootstrapBlazor/Localization/Json/JsonStringLocalizer.cs
Added new test case to verify the endless loop fix	Created ValidateFixEndlessLoop test method Added MockLocalizerFactory2 class for testing multiple localizer scenarios Implemented service provider based factory selection logic	test/UnitTest/Localization/JsonStringLocalizerTest.cs

Possibly linked issues

• bug(JsonStringLocalizer): add type check prevent endless loop #4652: PR fixes the endless loop in JsonStringLocalizer as described in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @izanhzh - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide more context in the PR description about the endless loop issue being fixed and how the changes address it. This helps future maintainers understand the changes without having to reference external links.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8fa755) to head (97b1dca).
Report is 122 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #4653   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27419     27419           
  Branches      3928      3928           
=========================================
  Hits         27419     27419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.