Skip to content

doc(Table): update bind-Items documentation #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2024
Merged

doc(Table): update bind-Items documentation #4870

merged 3 commits into from
Dec 18, 2024

Conversation

@yc-2503
Copy link
Contributor

@yc-2503 yc-2503 commented Dec 17, 2024 •
edited by ArgoZhang
Loading

doc(Table): update bind-Items documentation

Summary of the changes (Less than 80 chars)

修改 TablesEdit 的使用描述，使用内置的编辑需要正确配置 [Key]

Description

fixes #4871

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

feat: 增加 Table 内置编辑使用说明
ff71403 
增加 Table 内置编辑使用说明
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 17, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
Copy link

bb-auto bot commented Dec 17, 2024

Thanks for your PR, @yc-2503. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang December 17, 2024 05:34
sourcery-ai[bot]
sourcery-ai bot approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yc-2503 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang changed the title feat: 增加 Table 内置编辑使用说明 doc(Table): update bind-Items documentation Dec 17, 2024
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Dec 17, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 17, 2024
@ArgoZhang
Copy link
Member

ArgoZhang commented Dec 17, 2024

@yc-2503 签署 CLA

敲入 @microsoft-github-policy-service agree 即可

@codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1c48683) to head (59e644b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #4870   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          623       623           
  Lines        27832     27832           
  Branches      3982      3982           
=========================================
  Hits         27832     27832

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yc-2503
Copy link
Contributor Author

yc-2503 commented Dec 17, 2024

@microsoft-github-policy-service agree

@ArgoZhang ArgoZhang enabled auto-merge (squash) December 18, 2024 01:11
@ArgoZhang ArgoZhang merged commit d4f3675 into dotnetcore:main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArgoZhang ArgoZhang ArgoZhang approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

v9.0.0

Development

Successfully merging this pull request may close these issues.

doc(Table): update bind-Items documentation

2 participants

@yc-2503 @ArgoZhang