-
-
Notifications
You must be signed in to change notification settings - Fork 364
chore(Deploy): add deploy script #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds a deploy script for Linux and updates the Nginx configuration. The deploy script clones the BootstrapBlazor repository, installs necessary dependencies like Git and Nginx, copies configuration files, and sets up a systemd service. The Nginx configuration is modified to point to the correct certificate paths. Sequence diagram for Linux deployment processsequenceDiagram
participant S as System
participant D as deploy.sh
participant G as Git
participant N as Nginx
D->>S: Clean environment
D->>S: Update apt
D->>S: Install git
D->>G: Clone BootstrapBlazor
D->>S: Create directories
D->>S: Copy deployment scripts
D->>S: Install systemd service
D->>S: Install nginx
D->>N: Copy nginx config
D->>N: Copy SSL certificates
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded certificate. (link)
- Hardcoded certificate. (link)
- Hardcoded private key. (link)
- Hardcoded private key. (link)
Overall Comments:
- The deploy.sh script uses sudo commands throughout. Consider removing sudo from the script and instead documenting that it should be run with appropriate privileges. This is safer and more flexible for different deployment environments.
- Add error checking and exit on failure in deploy.sh. The script should verify each critical operation (git clone, directory creation, file copies) succeeds before continuing.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 4 blocking issues
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4921 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 628 628
Lines 28073 28073
Branches 4038 4038
=========================================
Hits 28073 28073 ☔ View full report in Codecov by Sentry. |
add deploy script
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4920
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add deploy, remove, and update scripts for Linux.
Enhancements:
Deployment: