-
-
Notifications
You must be signed in to change notification settings - Fork 364
doc(Table): add explain of binding complex object #4922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds an example of how to bind a complex object to a Table component. Sequence diagram for updating Company property in ComplexItemssequenceDiagram
participant User
participant Button
participant TablesColumn
participant ComplexItems
User->>Button: Click 'Set Company' button
Button->>TablesColumn: OnClickCompanyButton()
loop For each ComplexFoo in ComplexItems
TablesColumn->>ComplexItems: Set new Company with random name
end
TablesColumn-->>Button: Task.CompletedTask
Button-->>User: Update complete
Class diagram showing the new ComplexFoo and Company classesclassDiagram
class Foo {
+int Id
+string Name
+DateTime DateTime
+string Address
+int Count
+bool Complete
+EnumEducation Education
+int ReadonlyColumn
}
class ComplexFoo {
+int Age
+Company? Company
+ComplexFoo(int age)
+static ComplexFoo Generate(IStringLocalizer~Foo~ localizer)
+static List~ComplexFoo~ GenerateComplexFoo(IStringLocalizer~Foo~ localizer, int count)
}
class Company {
+string Name
+Company(string name)
}
Foo <|-- ComplexFoo
ComplexFoo o-- Company
note for ComplexFoo "New complex class that extends Foo"
note for Company "Simple class to demonstrate complex object binding"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @Lekco1320. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Lekco1320 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The diff shows modifications to localization files (en-US.json and zh-CN.json) but the actual changes are not visible. Please include these changes in the PR to ensure documentation is complete.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4922 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 628 628
Lines 28082 28082
Branches 4042 4042
=========================================
Hits 28082 28082 ☔ View full report in Codecov by Sentry. |
Add explain of binding complex object
Description
Closes #4907
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add an example to demonstrate how to bind complex objects to the table component.
New Features:
Tests: