-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(TableFilter): add @ keyword #4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR fixes a bug in the Sequence diagram showing the fixed LookupFilter property bindingsequenceDiagram
participant TF as TableFilter
participant LF as LookupFilter
participant Col as Column
TF->>Col: Check IsLookup()
alt IsLookup() is true
TF->>Col: Get LookupServiceKey
Col-->>TF: Return actual key value
TF->>LF: Create with correct LookupServiceKey
end
Class diagram showing the relationship between TableFilter and LookupFilterclassDiagram
class TableFilter {
+Column: ITableColumn
+Render()
}
class LookupFilter {
+Lookup: object
+LookupService: object
+LookupServiceKey: string
+LookupServiceData: object
+LookupStringComparison: StringComparison
+Type: Type
+IsShowSearch: bool
}
class Column {
+LookupServiceKey: string
+IsLookup(): bool
}
TableFilter --> LookupFilter: creates
TableFilter --> Column: uses
note for LookupFilter "Fixed: Now correctly receives Column.LookupServiceKey value"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AiYuZhen - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4932 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 628 628
Lines 28078 28086 +8
Branches 4043 4043
===========================================
+ Hits 28078 28085 +7
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: AiZhen <[email protected]> Co-Authored-By: Chason <[email protected]>
d766f62
|
@microsoft-github-policy-service agree |
feat(TableFilter)修复 TableFilter 属性 LookupServiceKey 赋值为字符串 Column.LookupServiceKey 问题
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
修复
TableFilter组件中的子组件LookupFilter的属性LookupServiceKey赋值为字符串"Column.LookupServiceKey"问题。Description
fixes #4938
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge