Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 30, 2024

style to fit the input-group mode

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4992

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Added clear button functionality to BootstrapInput when used inside a BootstrapInputGroup.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 30, 2024

Reviewer's Guide by Sourcery

This PR styles the BootstrapInput component to fit the input-group mode by adjusting border-radius and adding specific styles for clearable inputs within input groups.

Class diagram for BootstrapInput and InputGroup components

classDiagram
    class BootstrapInput {
        +bool Clearable
        +string Value
        +bool ShowLabel
        +string DisplayText
    }
    class BootstrapInputGroup {
    }
    class BootstrapInputGroupLabel {
        +bool ShowRequiredMark
        +string DisplayText
    }
    BootstrapInputGroup *-- BootstrapInput
    BootstrapInputGroup *-- BootstrapInputGroupLabel
    note for BootstrapInput "Added styling for clearable inputs
in input-group mode"
Loading

File-Level Changes

Change Details Files
Added support for the Clearable property within BootstrapInputGroup
  • Added examples of BootstrapInput with the Clearable property set to true inside a BootstrapInputGroup to demonstrate the styling changes.
  • Added new demo blocks to showcase the Clearable functionality within input groups
src/BootstrapBlazor.Server/Components/Samples/Inputs.razor
Adjusted the border-radius of BootstrapInput when used inside a BootstrapInputGroup
  • Added styles to remove the border-radius from the appropriate sides of a BootstrapInput when it's not the first or last child within a BootstrapInputGroup
src/BootstrapBlazor/Components/Input/BootstrapInputGroup.razor.scss
Updated the position of the clear button within BootstrapInput
  • Adjusted the right position of the clear button to 10px
src/BootstrapBlazor/Components/Input/BootstrapInput.razor.scss
Added localization strings for the new demo blocks
  • Added new localization strings for the title and introduction of the clearable input demo
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json
Updated project file
  • Modified the project file to include the changes related to the new styles and demo blocks
src/BootstrapBlazor/BootstrapBlazor.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#4992 Style the input component to fit the input-group mode

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 30, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 30, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) December 30, 2024 01:28
@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f83730d) to head (e07313a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4993   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          630       630           
  Lines        28105     28105           
  Branches      4030      4030           
=========================================
  Hits         28105     28105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 44afc80 into main Dec 30, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-input branch December 30, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Input): style to fit the input-group mode

2 participants