-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(Input): style to fit the input-group mode #4993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR styles the BootstrapInput component to fit the input-group mode by adjusting border-radius and adding specific styles for clearable inputs within input groups. Class diagram for BootstrapInput and InputGroup componentsclassDiagram
class BootstrapInput {
+bool Clearable
+string Value
+bool ShowLabel
+string DisplayText
}
class BootstrapInputGroup {
}
class BootstrapInputGroupLabel {
+bool ShowRequiredMark
+string DisplayText
}
BootstrapInputGroup *-- BootstrapInput
BootstrapInputGroup *-- BootstrapInputGroupLabel
note for BootstrapInput "Added styling for clearable inputs
in input-group mode"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4993 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 28105 28105
Branches 4030 4030
=========================================
Hits 28105 28105 ☔ View full report in Codecov by Sentry. |
style to fit the input-group mode
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4992
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: