Skip to content

fix(SelectTree): shoud set the default active node by Value on first render #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix(SelectTree): shoud set the default active node by Value on first render #5004

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c759de
fix: 修复 Value 设置 IsActive 状态逻辑
ArgoZhang Dec 31, 2024
f2fcd0d
chore: bump version 9.2.1-beta02
ArgoZhang Dec 31, 2024
adaad7c
test: 增加单元测试
ArgoZhang Dec 31, 2024
77a2114
refactor: 更改判定条件
ArgoZhang Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.2.1-beta01</Version>
<Version>9.2.1-beta02</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/BootstrapBlazor/Components/Select/SelectTree.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ private async Task TriggerItemChanged(Func<TreeViewItem<TValue>, bool> predicate
var currentItem = GetExpandedItems().FirstOrDefault(predicate);
if (currentItem != null)
{
currentItem.IsActive = true;
await ItemChanged(currentItem);
}
}
Expand Down
14 changes: 14 additions & 0 deletions test/UnitTest/Components/SelectTreeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,20 @@ public void IsPopover_Ok()
cut.DoesNotContain("data-bs-toggle=\"dropdown\"");
}

[Fact]
public void IsActive_Ok()
{
var items = TreeFoo.GetTreeItems();
var cut = Context.RenderComponent<SelectTree<TreeFoo>>(builder =>
{
builder.Add(p => p.Items, items);
builder.Add(p => p.Value, new TreeFoo() { Id = "1020", Text = "Navigation Two" });
});
var nodes = cut.FindAll(".tree-content");
Assert.Equal(3, nodes.Count);
Assert.True(nodes[1].ClassName == "tree-content active");
}

private List<TreeViewItem<string>> BindItems { get; } =
[
new TreeViewItem<string>("Test1")
Expand Down
Loading