-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(ICacheManager): add default cache policy #5176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a default cache policy to the ICacheManager implementation. It also refactors the CodeSnippetService to use the new cache policy and improve code readability. Sequence diagram for GetOrCreate cache operation with default policysequenceDiagram
participant Client
participant CacheManager
participant Cache
Client->>CacheManager: GetOrCreate(key, factory)
CacheManager->>Cache: GetOrCreate(key)
alt Item not in cache
Cache-->>CacheManager: Create new entry
CacheManager->>CacheManager: Execute factory
alt No expiration policy set
CacheManager->>Cache: Set sliding expiration (5 min)
end
CacheManager->>Cache: Store item
end
Cache-->>CacheManager: Return cached item
CacheManager-->>Client: Return item
Class diagram showing changes to CacheManager and CodeSnippetServiceclassDiagram
class ICacheManager {
+GetOrCreate<TItem>(key: object, factory: Func<ICacheEntry, TItem>): TItem
+Clear(key: object?): void
}
class CacheManager {
-IServiceProvider Provider
-IMemoryCache Cache
+GetOrCreate<TItem>(key: object, factory: Func<ICacheEntry, TItem>): TItem
+Clear(key: object?): void
}
class CodeSnippetService {
+GetCodeAsync(codeFile: string): Task<string>
+GetFileContentAsync(fileName: string): Task<string>
-ReadFileAsync(fileName: string): Task<string>
}
ICacheManager <|.. CacheManager
CodeSnippetService --> ICacheManager
note for CacheManager "Added default cache policy:
- 5 min sliding expiration if no policy set
- Special handling for dynamic assemblies"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide documentation explaining the rationale for removing FrozenDictionary and CacheManagerExtensions.cs. These are significant changes that should be justified in the PR description.
- Consider keeping FrozenDictionary for SourceCodes as it provides better performance for read-only scenarios. If there's a specific reason for removing it, please explain.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5176 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28139 28158 +19
Branches 4049 4052 +3
=========================================
+ Hits 28139 28158 +19 ☔ View full report in Codecov by Sentry. |
add default cache policy
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5175
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a default cache policy to ICacheManager to set a sliding expiration of 5 minutes if no expiration is specified.
New Features:
Enhancements: