-
-
Notifications
You must be signed in to change notification settings - Fork 365
chore(Deploy): update deploy script #5181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the deploy script to include additional steps for installing Chrome, fonts, and the .NET SDK. Flow diagram of updated deployment processflowchart TD
start[Start Deployment] --> clean[Clean Environment]
clean --> update[APT Update]
update --> git[Install Git]
git --> bb[Install BootstrapBlazor]
bb --> dir[Create BA/Blazor Directories]
dir --> scripts[Copy Scripts]
scripts --> service[Install BA Blazor Service]
service --> nginx[Install Nginx]
nginx --> config[Copy Nginx Config]
config --> cert[Copy Certificates]
cert --> chrome[Install Chrome]
chrome --> fonts[Install WQY Microhei Fonts]
fonts --> dotnet[Install .NET SDK 9.0]
dotnet --> finish[Finish Deployment]
style chrome fill:#90EE90
style fonts fill:#90EE90
style dotnet fill:#90EE90
note[New steps added] --> chrome
style note fill:#f9f,stroke:#333,stroke-width:2px
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding error handling to exit the script if any critical step fails (e.g., git clone, package downloads, installations)
- Consider pinning specific versions for Chrome and .NET SDK installations to ensure deployment reproducibility
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5181 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28158 28158
Branches 4052 4052
=========================================
Hits 28158 28158 ☔ View full report in Codecov by Sentry. |
update deploy script
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5180
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the deployment script to install additional dependencies, including Chrome, support fonts, and .NET 9.0 SDK. Improve logging by adding separators and descriptions to each step.
Enhancements:
Deployment: