feat(LoadModule): preventing OperationCancelException throw

[ArgoZhang]

preventing OperationCancelException throw

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #5187

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

• High
• Medium
• Low

[Justify the selection above]

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Prevent OperationCanceledException from being thrown when loading a module.

Bug Fixes:

• Fixed an issue where loading a module could throw an OperationCanceledException.

Tests:

• Updated tests to reflect the changes and ensure that the module loads correctly even when an OperationCanceledException occurs.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request prevents the throwing of OperationCanceledException when loading a JS module. It achieves this by catching the exception and continuing execution.

Sequence diagram for JS Module loading with error handling

sequenceDiagram
    participant App
    participant JSModuleExtensions
    participant JSRuntime

    App->>JSModuleExtensions: LoadModule(jsRuntime, path)
    JSModuleExtensions->>JSRuntime: InvokeAsync<IJSObjectReference>
    alt Success
        JSRuntime-->>JSModuleExtensions: Return JSObjectReference
    else OperationCanceledException
        JSRuntime-->>JSModuleExtensions: Throw OperationCanceledException
        Note over JSModuleExtensions: Catch and suppress exception
    end
    JSModuleExtensions-->>App: Return new JSModule

Loading

Class diagram for JSModule loading components

classDiagram
    class JSModuleExtensions {
        +LoadModule(IJSRuntime jsRuntime, string path) Task~JSModule~
    }
    class JSModule {
        -JSObjectReference _jsObjectReference
        +JSModule(JSObjectReference reference)
    }
    class IJSRuntime {
        +InvokeAsync<T>() ValueTask~T~
    }

    JSModule --> JSObjectReference
    JSModuleExtensions ..> JSModule: creates
    JSModuleExtensions ..> IJSRuntime: uses

Loading

File-Level Changes

Change	Details	Files
Prevented OperationCanceledException from being thrown when loading a JS module.	Added a catch block for OperationCanceledException. The catch block does not re-throw the exception.	src/BootstrapBlazor/Extensions/JSModuleExtensions.cs
Updated unit tests to reflect the change in exception handling.	Removed the test case that asserts a TaskCanceledException is thrown. Added a test case that asserts a module is loaded successfully when the underlying operation is cancelled.	test/UnitTest/Extensions/JSModuleExtensionsTest.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5187	Prevent OperationCanceledException from being thrown when loading a JavaScript module	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Silently catching OperationCanceledException without any handling or logging is not recommended. Consider either logging the exception, providing a way to indicate the failure to the caller, or letting it propagate if it represents a genuine error condition.
• The test changes reduce coverage of error scenarios by removing the explicit cancellation test. Please maintain or improve test coverage when modifying error handling behavior.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3ccfc9d) to head (035b929).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28158     28159    +1     
  Branches      4052      4052           
=========================================
+ Hits         28158     28159    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.