Skip to content

feat(LoadModule): preventing OperationCancelException throw #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

feat(LoadModule): preventing OperationCancelException throw #5188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba02b27
refactor: 增加 OperationCanceledException 异常忽略
ArgoZhang Jan 23, 2025
035b929
test: 更新单元测试
ArgoZhang Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/BootstrapBlazor/Extensions/JSModuleExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public static async Task<JSModule> LoadModule(this IJSRuntime jsRuntime, string
throw;
#endif
}
catch (OperationCanceledException) { }
return new JSModule(jSObjectReference);
}

Expand Down
9 changes: 3 additions & 6 deletions test/UnitTest/Extensions/JSModuleExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,10 @@ public async Task LoadModule_Ok()
{
var jsRuntime = Context.Services.GetRequiredService<IJSRuntime>();
await jsRuntime.LoadModule("./mock.js", "test");
}

[Fact]
public async Task LoadModule_Exception()
{
var jsRuntime = new MockJSRuntime();
await Assert.ThrowsAsync<TaskCanceledException>(() => jsRuntime.LoadModule("./mock.js", "test"));
var jsRuntime1 = new MockJSRuntime();
var module = await jsRuntime1.LoadModule("./mock.js", "test");
Assert.NotNull(module);

var jsRuntime2 = new JSExceptionJSRuntime();
await Assert.ThrowsAsync<JSException>(() => jsRuntime2.LoadModule("./mock.js", "test"));
Expand Down
Loading