feat(Drawer): add IsKeyboard parameter #5207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: ice6 <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: ice6 <[email protected]>
Contributor
Reviewer's Guide by SourceryThis pull request adds a new Sequence diagram for Drawer ESC key handlingsequenceDiagram
actor User
participant Drawer
participant EventHandler
participant JSInterop
User->>Drawer: Press ESC key
activate Drawer
Drawer->>EventHandler: Handle keyup event
EventHandler->>Drawer: Check if data-bb-keyboard='true'
alt IsKeyboard enabled
Drawer->>JSInterop: InvokeMethodAsync('Close')
JSInterop->>Drawer: Close drawer
Drawer-->>User: Drawer closes
else IsKeyboard disabled
Drawer-->>User: No action
end
deactivate Drawer
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28189 28194 +5
Branches 4056 4057 +1
=========================================
+ Hits 28189 28194 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add IsKeyboard parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #5206
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for closing the Drawer component with the ESC key when the
IsKeyboardparameter is set to true.New Features:
IsKeyboardparameter to theDrawercomponent to control whether it can be closed with the ESC key.Tests:
IsKeyboardparameter.