-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(ICacheManager): add prefix cache key #5210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a cache key prefix to all cache keys in the Sequence diagram for cache entry creation with sliding expirationsequenceDiagram
participant Client
participant CacheManager
participant Cache
Client->>CacheManager: GetOrCreateAsync(key, factory)
CacheManager->>Cache: GetOrCreateAsync(key)
Cache-->>CacheManager: Create new entry
CacheManager->>Cache: factory(entry)
Note over CacheManager: Check expiration settings
alt No expiration or priority set
CacheManager->>Cache: SetSlidingExpiration(5 minutes)
end
Cache-->>CacheManager: Return cached item
CacheManager-->>Client: Return result
Class diagram for CacheManager changesclassDiagram
class CacheManager {
-string CacheKeyPrefix
-static CacheManager Instance
+GetOrCreate<TItem>(object key, Func factory)
+GetOrCreateAsync<TItem>(object key, Func factory)
+ElementCount(object value)
+GetJsonStringByTypeName(Assembly assembly, string cultureName)
+GetNullableBoolItems(Type modelType, string fieldName)
+GetPropertyValue<TModel, TResult>(TModel model, string fieldName)
}
note for CacheManager "Added CacheKeyPrefix constant
Modified cache key generation
Added default sliding expiration"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add documentation about the cache key format and prefix usage, as this is a potentially breaking change for users who directly interact with the cache
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5210 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28194 28198 +4
Branches 4057 4058 +1
=========================================
+ Hits 28194 28198 +4 ☔ View full report in Codecov by Sentry. |
add prefix cache key
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5209
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a prefix to cache keys.
Bug Fixes:
Tests: