-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Drawer): auto focus when drawer shown #5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request implements auto focus when the drawer is shown. It also refactors the drawer open/close logic to be more concise. Sequence diagram for drawer show/hide behaviorsequenceDiagram
participant U as User
participant D as Drawer
participant A as Animation Frame
U->>D: Open drawer
D->>D: Add overflow-hidden to body
D->>A: Request animation frame
A-->>D: Animation frame callback
D->>D: Add show class
D->>D: Set focus
U->>D: Close drawer
D->>D: Remove show class
D->>A: Request animation frame
A-->>D: Animation frame callback
D->>D: Remove overflow-hidden from body
State diagram for drawer componentstateDiagram-v2
[*] --> Closed
Closed --> Opening: User opens drawer
Opening --> Open: Animation complete
Open --> Closing: User closes drawer
Closing --> Closed: Animation complete
state Open {
[*] --> Focused: Auto focus
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template in English and check the appropriate boxes for verification, risk assessment, and other checks. This helps maintainers better understand and review the changes.
- Consider documenting the accessibility implications of auto-focusing the drawer when shown, and whether this behavior should be configurable.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28194 28198 +4
Branches 4057 4058 +1
=========================================
+ Hits 28194 28198 +4 ☔ View full report in Codecov by Sentry. |
auto focus when drawer shown
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5208
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: