-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(ICacheManager): add TryGetCacheEntry method #5216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Sequence diagram for TryGetCacheEntry method flowsequenceDiagram
participant Client
participant CacheManager
participant MemoryCache
participant CoherentState
Client->>+CacheManager: TryGetCacheEntry(key)
alt key is null
CacheManager-->>Client: return false
else key is not null
CacheManager->>MemoryCache: GetCoherentState()
MemoryCache-->>CacheManager: coherentState
CacheManager->>CoherentState: GetAllValues()
CoherentState-->>CacheManager: values
CacheManager->>CacheManager: Find entry by key
alt entry found
CacheManager-->>Client: return true, entry
else entry not found
CacheManager-->>Client: return false, null
end
end
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Using reflection to access private members of MemoryCache is fragile and may break in future .NET versions. Consider adding error handling and documenting this implementation detail as a potential maintenance risk.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5216 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28198 28227 +29
Branches 4058 4063 +5
=========================================
+ Hits 28198 28227 +29 ☔ View full report in Codecov by Sentry. |
add TryGetCacheEntry method
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5215
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a
TryGetCacheEntrymethod to theICacheManagerinterface and its implementation. This allows retrieving a cache entry by key, returning a boolean indicating success and the entry itself if found.New Features:
TryGetCacheEntrymethod to retrieve cache entries by key, providing more control over cache access.Tests:
TryGetCacheEntrymethod.