-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(SelectTable): add EmptyTemplate parameter #5217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces the EmptyTemplate parameter to the SelectTable component, allowing users to display a custom template when no data is available. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28227 28229 +2
Branches 4063 4063
=========================================
+ Hits 28227 28229 +2 ☔ View full report in Codecov by Sentry. |
add EmptyTemplate parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5212
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add an
EmptyTemplateparameter to theSelectTablecomponent to allow custom content to be displayed when no data is available.New Features:
EmptyTemplateparameter to theSelectTablecomponent. This parameter allows developers to customize the content displayed when the table is empty.Tests:
EmptyTemplatefunctionality.