-
-
Notifications
You must be signed in to change notification settings - Fork 365
doc(CacheList): update GetSlidingLeftTime logic #5228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe pull request updates the GetSlidingLeftTime method to ensure that the returned TimeSpan is never negative. This is achieved by adding a check to see if the calculated time is less than zero, and if so, returning TimeSpan.Zero. Sequence diagram for GetSlidingLeftTime calculationsequenceDiagram
participant Client
participant CacheEntry
participant GetSlidingLeftTime
Client->>GetSlidingLeftTime: Request remaining sliding time
GetSlidingLeftTime->>CacheEntry: Get last accessed time
CacheEntry-->>GetSlidingLeftTime: Return last accessed time
alt last accessed is null
GetSlidingLeftTime-->>Client: Return TimeSpan.Zero
else last accessed exists
GetSlidingLeftTime->>CacheEntry: Get sliding expiration
CacheEntry-->>GetSlidingLeftTime: Return sliding expiration
Note over GetSlidingLeftTime: Calculate remaining time
alt calculated time < 0
GetSlidingLeftTime-->>Client: Return TimeSpan.Zero
else calculated time >= 0
GetSlidingLeftTime-->>Client: Return calculated time
end
end
Flow diagram for GetSlidingLeftTime logicflowchart TD
A[Start] --> B{Last accessed time exists?}
B -->|No| C[Return TimeSpan.Zero]
B -->|Yes| D[Calculate remaining time]
D --> E{Remaining time < 0?}
E -->|Yes| F[Return TimeSpan.Zero]
E -->|No| G[Return calculated time]
C --> H[End]
F --> H
G --> H
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 635 635
Lines 28248 28248
Branches 4068 4068
=========================================
Hits 28248 28248 ☔ View full report in Codecov by Sentry. |
update GetSlidingLeftTime logic
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5227
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: