Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 27, 2025

update GetSlidingLeftTime logic

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5227

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix a bug where GetSlidingLeftTime could return a negative time.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2025

Reviewer's Guide by Sourcery

The pull request updates the GetSlidingLeftTime method to ensure that the returned TimeSpan is never negative. This is achieved by adding a check to see if the calculated time is less than zero, and if so, returning TimeSpan.Zero.

Sequence diagram for GetSlidingLeftTime calculation

sequenceDiagram
    participant Client
    participant CacheEntry
    participant GetSlidingLeftTime

    Client->>GetSlidingLeftTime: Request remaining sliding time
    GetSlidingLeftTime->>CacheEntry: Get last accessed time
    CacheEntry-->>GetSlidingLeftTime: Return last accessed time
    alt last accessed is null
        GetSlidingLeftTime-->>Client: Return TimeSpan.Zero
    else last accessed exists
        GetSlidingLeftTime->>CacheEntry: Get sliding expiration
        CacheEntry-->>GetSlidingLeftTime: Return sliding expiration
        Note over GetSlidingLeftTime: Calculate remaining time
        alt calculated time < 0
            GetSlidingLeftTime-->>Client: Return TimeSpan.Zero
        else calculated time >= 0
            GetSlidingLeftTime-->>Client: Return calculated time
        end
    end
Loading

Flow diagram for GetSlidingLeftTime logic

flowchart TD
    A[Start] --> B{Last accessed time exists?}
    B -->|No| C[Return TimeSpan.Zero]
    B -->|Yes| D[Calculate remaining time]
    D --> E{Remaining time < 0?}
    E -->|Yes| F[Return TimeSpan.Zero]
    E -->|No| G[Return calculated time]
    C --> H[End]
    F --> H
    G --> H
Loading

File-Level Changes

Change Details Files
The GetSlidingLeftTime method was updated to prevent returning negative TimeSpans.
  • Added a check to see if the calculated time is less than zero.
  • If the calculated time is less than zero, return TimeSpan.Zero.
src/BootstrapBlazor.Server/Extensions/ICacheEntryExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5227 Update the GetSlidingLeftTime logic in the CacheList component

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jan 27, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Jan 27, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 27, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3e217f1) to head (e506f54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5228   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          635       635           
  Lines        28248     28248           
  Branches      4068      4068           
=========================================
  Hits         28248     28248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 1d9f784 into main Jan 27, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the doc-cache branch January 27, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(CacheList): update GetSlidingLeftTime logic

2 participants