-
-
Notifications
You must be signed in to change notification settings - Fork 365
doc(Select): update ShowSearch sample code #5241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the ShowSearch sample code for the Select component to use a switch to control the ShowSearch property, and adjusts the search icon position. Class diagram for Select component changesclassDiagram
class Selects {
-bool _showSearch
-bool _showPopoverSearch
-bool _isShowSearchClearable
-bool _isClearable
}
class Select {
+bool ShowSearch
+bool IsPopover
}
Selects --> Select: uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 637 637
Lines 28317 28317
Branches 4078 4078
=========================================
Hits 28317 28317 ☔ View full report in Codecov by Sentry. |
update ShowSearch sample code
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5240
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: