-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(IDynamicObject): remove SupportComplexProperty parameter #5252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request removes the Class diagram showing the refactored property access methodsclassDiagram
class Utility {
+GetPropertyValue<TModel, TResult>(model: TModel, fieldName: string) TResult
+GetPropertyValue(model: object, fieldName: string) object?
+SetPropertyValue<TModel, TValue>(model: TModel, fieldName: string, value: TValue) void
}
class CacheManager {
+GetPropertyValue<TModel, TResult>(model: TModel, fieldName: string) TResult
-GetValue<TModel, TResult>(model: TModel, fieldName: string) TResult
+SetPropertyValue<TModel, TValue>(model: TModel, fieldName: TValue, value: TValue) void
}
class LambdaExtensions {
+GetPropertyValueLambda<TModel, TResult>(model: TModel, propertyName: string) Expression
+SetPropertyValueLambda<TModel, TValue>(model: TModel, propertyName: string) Expression
}
Utility ..> CacheManager: uses
CacheManager ..> LambdaExtensions: uses
note for LambdaExtensions "Complex property handling
now based on property name
and dynamic assembly check"
Flow diagram for property value access logicflowchart TD
A[Get/Set Property Value] --> B{Is Dynamic Object?}
B -->|Yes| C[Use Dynamic Object Handler]
B -->|No| D{Contains '.' in property name?}
D -->|Yes| E[Use Complex Property Handler]
D -->|No| F[Use Simple Property Handler]
note[The supportComplexProperty parameter
has been removed and logic is now
based on property name and object type]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5252 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 639 639
Lines 28732 28733 +1
Branches 4080 4080
=========================================
+ Hits 28732 28733 +1 ☔ View full report in Codecov by Sentry. |
remove SupportComplexProperty parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5251
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: