-
-
Notifications
You must be signed in to change notification settings - Fork 364
doc(MultiSelect): update sample code support flags enum #5257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the sample code for the MultiSelect component to properly support the Flags enum. Class diagram for MultiSelect component with Flags enum supportclassDiagram
class MultiSelect {
+TValue Value
+bool ShowSearch
+bool ShowToolbar
+bool IsPopover
+bool IsEditable
+int Max
+int Min
+OnSelectedItemsChanged()
+OnSearchTextChanged()
+OnEditCallback()
}
class MultiSelectEnumFoo {
<<enumeration>>
None
Value1
Value2
Value3
}
MultiSelect ..> MultiSelectEnumFoo : supports
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more detail in the PR description about how these changes relate to updating the flags enum support mentioned in the title. This will help future maintainers understand the context and purpose of these changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 639 639
Lines 28756 28756
Branches 4085 4085
=========================================
Hits 28756 28756 ☔ View full report in Codecov by Sentry. |
update sample code support flags enum
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5256
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the sample code to support the Flags enum in the MultiSelect component.
Enhancements:
Documentation: