-
-
Notifications
You must be signed in to change notification settings - Fork 364
chore(ErroLogger): add navigation url info #5262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds the current navigation URL to the error logs generated by the BootstrapBlazorErrorBoundary component. Sequence diagram for error logging with navigation URLsequenceDiagram
participant User
participant ErrorBoundary as BootstrapBlazorErrorBoundary
participant ToastService
participant Logger
participant NavigationManager
User->>ErrorBoundary: Triggers error
ErrorBoundary->>ToastService: Display error toast
ErrorBoundary->>NavigationManager: Get current URL
ErrorBoundary->>Logger: Log error with URL info
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template fully, including risk assessment, verification steps, and self-check items. This helps maintain project quality and documentation standards.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 639 639
Lines 28756 28757 +1
Branches 4085 4085
=========================================
+ Hits 28756 28757 +1 ☔ View full report in Codecov by Sentry. |
add navigation url info
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5261
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: