-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Tab): add ShowActiveBar parameter #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces the Updated class diagram for the Tab componentclassDiagram
class Tab {
bool ShowExtendButtons
bool ShowNavigatorButtons
bool ShowActiveBar
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a test case that verifies the active bar is shown by default.
- The added test case could be improved by using
FindorFindAllto locate the element instead ofContainsandDoesNotContain.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a CSS class to the active bar element to allow for more flexible styling.
- The added attribute description in
BootstrapBlazor.Server/Components/Samples/Tabs.razor.csis duplicated, please remove the first one.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29253 29254 +1
Branches 4131 4131
=========================================
+ Hits 29253 29254 +1 ☔ View full report in Codecov by Sentry. |
add ShowActiveBar parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5387
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request introduces the
ShowActiveBarparameter to the Tab component, allowing developers to toggle the visibility of the active tab indicator bar. This enhancement provides more flexibility in customizing the appearance of the Tab component.New Features:
ShowActiveBarparameter to the Tab component to control the visibility of the active tab indicator bar.Enhancements:
Documentation:
ShowActiveBarparameter.Tests:
ShowActiveBarparameter.