Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 18, 2025

add ShowActiveBar parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5387

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

This pull request introduces the ShowActiveBar parameter to the Tab component, allowing developers to toggle the visibility of the active tab indicator bar. This enhancement provides more flexibility in customizing the appearance of the Tab component.

New Features:

  • Added a new ShowActiveBar parameter to the Tab component to control the visibility of the active tab indicator bar.

Enhancements:

  • The Tab component now supports an option to hide the active tab indicator bar.

Documentation:

  • Updated the documentation for the Tab component to include the new ShowActiveBar parameter.

Tests:

  • Added a unit test to verify the functionality of the ShowActiveBar parameter.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 18, 2025

Reviewer's Guide by Sourcery

This pull request introduces the ShowActiveBar parameter to the Tab component, enabling developers to show or hide the active tab indicator bar. A unit test has been added to verify the functionality.

Updated class diagram for the Tab component

classDiagram
  class Tab {
    bool ShowExtendButtons
    bool ShowNavigatorButtons
    bool ShowActiveBar
  }
Loading

File-Level Changes

Change Details Files
Introduced a new parameter ShowActiveBar to control the visibility of the active tab indicator bar.
  • Added ShowActiveBar property to the Tab component.
  • Modified the Tab component's rendering logic to conditionally display the active bar based on the ShowActiveBar property.
  • Added a unit test to verify the ShowActiveBar parameter functionality.
test/UnitTest/Components/TabTest.cs
src/BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs
src/BootstrapBlazor/Components/Tab/Tab.razor.cs
src/BootstrapBlazor/Components/Tab/Tab.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#5387 Add a ShowActiveBar parameter to the Tab component to control the visibility of the active tab indicator bar.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 18, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 18, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Feb 18, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a test case that verifies the active bar is shown by default.
  • The added test case could be improved by using Find or FindAll to locate the element instead of Contains and DoesNotContain.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a CSS class to the active bar element to allow for more flexible styling.
  • The added attribute description in BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs is duplicated, please remove the first one.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e339197) to head (1d96f5d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5388   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          645       645           
  Lines        29253     29254    +1     
  Branches      4131      4131           
=========================================
+ Hits         29253     29254    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 2b1ab85 into main Feb 18, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-tab branch February 18, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Tab): add ShowActiveBar parameter

2 participants